Re: [PATCH] f2fs: change the codes of checking CP_CRC_RECOVERY_FLAG to macro

From	Yunlong Song <yunlong.song@huawei.com>
Newsgroups	linux.kernel
Subject	Re: [PATCH] f2fs: change the codes of checking CP_CRC_RECOVERY_FLAG to macro
Date	2017-02-25 09:20 +0100
Message-ID	<teFKa-4VJ-15@gated-at.bofh.it> (permalink)
References	(1 earlier) <tels6-7i4-19@gated-at.bofh.it> <tem4N-7KI-13@gated-at.bofh.it> <temo9-7SR-13@gated-at.bofh.it> <temHv-85C-23@gated-at.bofh.it> <tesDg-3VB-13@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw

On 2017/2/25 2:12, Jaegeuk Kim wrote:

> 
> This is to handle only one case in which:
> 
> 1. uses old kernel without this flag,
> 2. calls fsync and gets sudden power-cut,
> 3. updates new kernel having this flag before mount.
> 
> Then, if we do not check this flag at mount time, we will lose the last fsync'ed
> node blocks.
> 

So I just send a v2 patch to only change to macro in fill_node_footer_blkaddr and
allocate_segment_by_default, these two functions are called frequently, so it is
better to use macro code. And I remain the original checking code in is_recoverable_dnode,
this function is called only once after mount, it's OK.

-- 
Thanks,
Yunlong Song

Thread

[PATCH] f2fs: change the codes of checking CP_CRC_RECOVERY_FLAG to macro Yunlong Song <yunlong.song@huawei.com> - 2017-02-24 11:00 +0100
  Re: [PATCH] f2fs: change the codes of checking CP_CRC_RECOVERY_FLAG  to macro Chao Yu <yuchao0@huawei.com> - 2017-02-24 11:40 +0100
    Re: [PATCH] f2fs: change the codes of checking CP_CRC_RECOVERY_FLAG  to macro Yunlong Song <yunlong.song@huawei.com> - 2017-02-24 12:20 +0100
      Re: [PATCH] f2fs: change the codes of checking CP_CRC_RECOVERY_FLAG  to macro Chao Yu <yuchao0@huawei.com> - 2017-02-24 12:40 +0100
        Re: [PATCH] f2fs: change the codes of checking CP_CRC_RECOVERY_FLAG  to macro Yunlong Song <yunlong.song@huawei.com> - 2017-02-24 13:00 +0100
          Re: [PATCH] f2fs: change the codes of checking CP_CRC_RECOVERY_FLAG  to macro Jaegeuk Kim <jaegeuk@kernel.org> - 2017-02-24 19:20 +0100
            Re: [PATCH] f2fs: change the codes of checking CP_CRC_RECOVERY_FLAG  to macro Chao Yu <yuchao0@huawei.com> - 2017-02-25 02:00 +0100
            Re: [PATCH] f2fs: change the codes of checking CP_CRC_RECOVERY_FLAG  to macro Yunlong Song <yunlong.song@huawei.com> - 2017-02-25 09:20 +0100
  [PATCH v2] f2fs: change the codes of checking CP_CRC_RECOVERY_FLAG to macro Yunlong Song <yunlong.song@huawei.com> - 2017-02-25 09:00 +0100
    Re: [PATCH v2] f2fs: change the codes of checking  CP_CRC_RECOVERY_FLAG to macro Jaegeuk Kim <jaegeuk@kernel.org> - 2017-02-25 19:50 +0100

csiph-web