Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1588072

Re: [Outreachy kernel] [PATCH] staging: ks7010: codes in the comments are removed

Show all headers | View raw

Remember to use the imperative and to make your subject lines as short as
possible.  Here the subject line could be "remove code in comments".

julia

On Sat, 25 Feb 2017, Arushi Singhal wrote:

> Commenting Code Is a Bad Idea.
> Comments are their to explain the code and how the code achieves its
> goal and as codes in the comments  does not explain what the code is
> doing so there is no use of commenting them.
> So in thos patch codes in the comments are removed.
>
> Signed-off-by: Arushi Singhal <arushisinghal19971997@gmail.com>
> ---
>  drivers/staging/ks7010/ks7010_sdio.c | 4 ----
>  1 file changed, 4 deletions(-)
>
> diff --git a/drivers/staging/ks7010/ks7010_sdio.c b/drivers/staging/ks7010/ks7010_sdio.c
> index 2c263f98bdbb..54aa2e2f516f 100644
> --- a/drivers/staging/ks7010/ks7010_sdio.c
> +++ b/drivers/staging/ks7010/ks7010_sdio.c
> @@ -495,10 +495,6 @@ static void ks7010_rw_function(struct work_struct *work)
>  	/* wiat after WAKEUP */
>  	while (time_after(priv->last_wakeup + ((30 * HZ) / 1000), jiffies)) {
>  		DPRINTK(4, "wait after WAKEUP\n");
> -/*
> - *   queue_delayed_work(priv->ks_wlan_hw.ks7010sdio_wq,&priv->ks_wlan_hw.rw_wq,
> - *   (priv->last_wakeup + ((30*HZ)/1000) - jiffies));
> - */
>  		dev_info(&priv->ks_wlan_hw.sdio_card->func->dev,
>  			 "wake: %lu %lu\n",
>  			 priv->last_wakeup + (30 * HZ) / 1000,
> --
> 2.11.0
>
> --
> You received this message because you are subscribed to the Google Groups "outreachy-kernel" group.
> To unsubscribe from this group and stop receiving emails from it, send an email to outreachy-kernel+unsubscribe@googlegroups.com.
> To post to this group, send email to outreachy-kernel@googlegroups.com.
> To view this discussion on the web visit https://groups.google.com/d/msgid/outreachy-kernel/20170224231154.GA32083%40arushi-HP-Pavilion-Notebook.
> For more options, visit https://groups.google.com/d/optout.
>

Back to linux.kernel | Previous | Next — Previous in thread | Find similar | Unroll thread

Thread

[PATCH] staging: ks7010: codes in the comments are removed Arushi Singhal <arushisinghal19971997@gmail.com> - 2017-02-25 00:20 +0100
  Re: [Outreachy kernel] [PATCH] staging: ks7010: codes in the comments  are removed Julia Lawall <julia.lawall@lip6.fr> - 2017-02-25 07:40 +0100

csiph-web