Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1588066

[PATCH 5/6] ARM: dts: socfpga: Remove unit name for LEDs in EBV SOCrates

Show all headers | View raw

GPIO LEDs in the Cyclone5 EBV SOCrates board have a unit name but no reg
property. Indeed, GPIO LEDs do not need such a property. They do not
need a unit name neither. This will trigger the following warnings when
compiled with W=1:

Node /gpio-leds/led@0 has a unit name, but no reg property
Node /gpio-leds/led@1 has a unit name, but no reg property
Node /gpio-leds/led@2 has a unit name, but no reg property

The solution is to remove the unit name. In order to have unique node
names, a rename is necessary. This should be harmless as all the LEDs
have a 'label' property, hence their name do not derive from the node
name and will stay the same after this patch.

Signed-off-by: Florian Vaussard <florian.vaussard@heig-vd.ch>
---
 arch/arm/boot/dts/socfpga_cyclone5_socrates.dts | 6 +++---
 1 file changed, 3 insertions(+), 3 deletions(-)

diff --git a/arch/arm/boot/dts/socfpga_cyclone5_socrates.dts b/arch/arm/boot/dts/socfpga_cyclone5_socrates.dts
index 8e3b017..53bf99e 100644
--- a/arch/arm/boot/dts/socfpga_cyclone5_socrates.dts
+++ b/arch/arm/boot/dts/socfpga_cyclone5_socrates.dts
@@ -60,18 +60,18 @@
 &leds {
 	compatible = "gpio-leds";
 
-	led@0 {
+	led0 {
 		label = "led:green:heartbeat";
 		gpios = <&porta 28 1>;
 		linux,default-trigger = "heartbeat";
 	};
 
-	led@1 {
+	led1 {
 		label = "led:green:D7";
 		gpios = <&portb 19 1>;
 	};
 
-	led@2 {
+	led2 {
 		label = "led:green:D8";
 		gpios = <&portb 25 1>;
 	};
-- 
2.7.4

Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread

Thread

[PATCH 0/6] ARM: dts: socfpga: Fix dtc warnings Florian Vaussard <florian.vaussard@gmail.com> - 2017-02-25 07:00 +0100
  [PATCH 5/6] ARM: dts: socfpga: Remove unit name for LEDs in EBV SOCrates Florian Vaussard <florian.vaussard@gmail.com> - 2017-02-25 07:00 +0100
  [PATCH 4/6] ARM: dts: socfpga: Remove unneeded reg from stmpe_touchscreen Florian Vaussard <florian.vaussard@gmail.com> - 2017-02-25 07:00 +0100
  [PATCH 3/6] ARM: dts: socfpga: Remove unneeded unit names Florian Vaussard <florian.vaussard@gmail.com> - 2017-02-25 07:00 +0100
  [PATCH 2/6] ARM: dts: socfpga: Add unit name to memory nodes Florian Vaussard <florian.vaussard@gmail.com> - 2017-02-25 07:00 +0100
  [PATCH 6/6] ARM: dts: socfpga: Do not include skeleton.dtsi Florian Vaussard <florian.vaussard@gmail.com> - 2017-02-25 07:00 +0100
  [PATCH 1/6] ARM: dts: socfpga: Add unit name to clock nodes Florian Vaussard <florian.vaussard@gmail.com> - 2017-02-25 07:00 +0100
  Re: [PATCH 0/6] ARM: dts: socfpga: Fix dtc warnings Dinh Nguyen <dinguyen@kernel.org> - 2017-02-27 17:50 +0100
    Re: [PATCH 0/6] ARM: dts: socfpga: Fix dtc warnings Florian Vaussard <florian.vaussard@heig-vd.ch> - 2017-02-28 12:30 +0100

csiph-web