Re: [PATCH] staging: bcm2835: Fix a memory leak in error handling path

From	Dan Carpenter <dan.carpenter@oracle.com>
Newsgroups	linux.kernel
Subject	Re: [PATCH] staging: bcm2835: Fix a memory leak in error handling path
Date	2017-02-25 05:20 +0100
Message-ID	<teBZT-2jg-1@gated-at.bofh.it> (permalink)
References	<tcx4m-6fm-5@gated-at.bofh.it> <tenkd-7b-1@gated-at.bofh.it> <teuc2-4Ze-19@gated-at.bofh.it> <tevUu-6cZ-33@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw

On Fri, Feb 24, 2017 at 10:38:38PM +0100, Stefan Wahren wrote:
> 
> > Dan Carpenter <dan.carpenter@oracle.com> hat am 24. Februar 2017 um 20:57 geschrieben:
> > 
> > 
> > On Fri, Feb 24, 2017 at 01:37:30PM +0100, Stefan Wahren wrote:
> > > Hi Christophe,
> > > 
> > > Am 19.02.2017 um 11:34 schrieb Christophe JAILLET:
> > > >If 'kzalloc()' fails, we should release resources allocated so far, just as
> > > >done in all other cases in this function.
> > > >
> > > >Signed-off-by: Christophe JAILLET <christophe.jaillet@wanadoo.fr>
> > > >---
> > > >Not sure that the error handling path is correct.
> > > >Is 'gdev[0]' freed? Should it be?
> > > 
> > 
> > Yes, but I already sent a patch to fix this and your leak as well and
> > Greg merged it.
> 
> My leak? I'm confused.

The one you're fixing I mean.

Back to linux.kernel | Previous | Next — Previous in thread | Find similar | Unroll thread

Thread

[PATCH] staging: bcm2835: Fix a memory leak in error handling path Christophe JAILLET <christophe.jaillet@wanadoo.fr> - 2017-02-19 11:40 +0100
  Re: [PATCH] staging: bcm2835: Fix a memory leak in error handling  path Stefan Wahren <stefan.wahren@i2se.com> - 2017-02-24 13:40 +0100
    Re: [PATCH] staging: bcm2835: Fix a memory leak in error handling  path Dan Carpenter <dan.carpenter@oracle.com> - 2017-02-24 21:00 +0100
      Re: [PATCH] staging: bcm2835: Fix a memory leak in error handling  path Stefan Wahren <stefan.wahren@i2se.com> - 2017-02-24 22:50 +0100
        Re: [PATCH] staging: bcm2835: Fix a memory leak in error handling  path Dan Carpenter <dan.carpenter@oracle.com> - 2017-02-25 05:20 +0100

csiph-web