Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]
Groups > linux.kernel > #1587029
| From | Andi Kleen <andi@firstfloor.org> |
|---|---|
| Newsgroups | linux.kernel |
| Subject | Re: [BUG] msr-trace.h:42 suspicious rcu_dereference_check() usage! |
| Date | 2017-02-23 18:20 +0100 |
| Message-ID | <te5dE-4ir-1@gated-at.bofh.it> (permalink) |
| References | <sFL7H-2pc-3@gated-at.bofh.it> <sFT5f-7LV-3@gated-at.bofh.it> <te0GZ-1dj-11@gated-at.bofh.it> |
| Organization | linux.* mail to news gateway |
> > diff --git a/arch/x86/kernel/process.c b/arch/x86/kernel/process.c
> > index 0888a879120f..d6c6aa80675f 100644
> > --- a/arch/x86/kernel/process.c
> > +++ b/arch/x86/kernel/process.c
> > @@ -357,7 +357,7 @@ static void amd_e400_idle(void)
> > if (!amd_e400_c1e_detected) {
> > u32 lo, hi;
> >
> > - rdmsr(MSR_K8_INT_PENDING_MSG, lo, hi);
> > + RCU_NONIDLE(rdmsr(MSR_K8_INT_PENDING_MSG, lo, hi));
> >
> > if (lo & K8_INTP_C1E_ACTIVE_MASK) {
> > amd_e400_c1e_detected = true;
>
> hum, I might have missed some other solution in discussion,
> and can't see this one being pulled in.. should I resend this?
I suppose you could also use the new notrace msr variant.
BTW this check is quite annoying.
-Andi
Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread
Re: [BUG] msr-trace.h:42 suspicious rcu_dereference_check() usage! Jiri Olsa <jolsa@redhat.com> - 2017-02-23 13:30 +0100
Re: [BUG] msr-trace.h:42 suspicious rcu_dereference_check() usage! Andi Kleen <andi@firstfloor.org> - 2017-02-23 18:20 +0100
Re: [BUG] msr-trace.h:42 suspicious rcu_dereference_check() usage! Peter Zijlstra <peterz@infradead.org> - 2017-02-23 18:30 +0100
Re: [BUG] msr-trace.h:42 suspicious rcu_dereference_check() usage! Borislav Petkov <bp@alien8.de> - 2017-02-23 19:30 +0100
csiph-web