Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]


Groups > linux.kernel > #1586978

net/sched/act_pedit.c:261:2-3: Unneeded semicolon

From kbuild test robot <fengguang.wu@intel.com>
Newsgroups linux.kernel
Subject net/sched/act_pedit.c:261:2-3: Unneeded semicolon
Date 2017-02-23 17:00 +0100
Message-ID <te3Ye-3fj-25@gated-at.bofh.it> (permalink)
Organization linux.* mail to news gateway

Show all headers | View raw


tree:   https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git master
head:   bc49a7831b1137ce1c2dda1c57e3631655f5d2ae
commit: 71d0ed7079dffbc5cd0941d77d9b84e04109c9bb net/act_pedit: Support using offset relative to the conventional network headers
date:   13 days ago


coccinelle warnings: (new ones prefixed by >>)

>> net/sched/act_pedit.c:261:2-3: Unneeded semicolon

vim +261 net/sched/act_pedit.c

   245		case TCA_PEDIT_KEY_EX_HDR_TYPE_NETWORK:
   246		case TCA_PEDIT_KEY_EX_HDR_TYPE_IP4:
   247		case TCA_PEDIT_KEY_EX_HDR_TYPE_IP6:
   248			*hoffset = skb_network_offset(skb);
   249			ret = 0;
   250			break;
   251		case TCA_PEDIT_KEY_EX_HDR_TYPE_TCP:
   252		case TCA_PEDIT_KEY_EX_HDR_TYPE_UDP:
   253			if (skb_transport_header_was_set(skb)) {
   254				*hoffset = skb_transport_offset(skb);
   255				ret = 0;
   256			}
   257			break;
   258		default:
   259			ret = -EINVAL;
   260			break;
 > 261		};
   262	
   263		return ret;
   264	}
   265	
   266	static int tcf_pedit(struct sk_buff *skb, const struct tc_action *a,
   267			     struct tcf_result *res)
   268	{
   269		struct tcf_pedit *p = to_pedit(a);

---
0-DAY kernel test infrastructure                Open Source Technology Center
https://lists.01.org/pipermail/kbuild-all                   Intel Corporation

Back to linux.kernel | Previous | Next | Find similar | Unroll thread


Thread

net/sched/act_pedit.c:261:2-3: Unneeded semicolon kbuild test robot <fengguang.wu@intel.com> - 2017-02-23 17:00 +0100

csiph-web