Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]


Groups > linux.kernel > #1586926

Re: [PATCH] arm64: Fix the kernel panic() on QDF2400 platform

From Will Deacon <will.deacon@arm.com>
Newsgroups linux.kernel
Subject Re: [PATCH] arm64: Fix the kernel panic() on QDF2400 platform
Date 2017-02-23 15:50 +0100
Message-ID <te2Su-2AJ-15@gated-at.bofh.it> (permalink)
References <tdSgp-3Ew-1@gated-at.bofh.it>
Organization linux.* mail to news gateway

Show all headers | View raw


On Wed, Feb 22, 2017 at 09:10:48PM -0600, Shanker Donthineni wrote:
> The commit 38fd94b0 'arm64: Work around Falkor erratum 1003' has
> been added to fix the hardware bug but causing a system crash.
> The value of the register x1 which contains 'struct mm_struct *'
> should be preserved inside macro pre_ttbr0_update_workaround.
> 
> Macro pre_ttbr0_update_workaround expects 2nd and 3rd arguments
> are temporary registers. Don't clobber register x1, Otherwise
> the next load operation 'mmid x1 x1' access the invalid address.

Whilst I'm pleased that you've sent a fix (and I'll pick it up), I have
to ask... did anybody actually test the original patch? If so, why wasn't
this found earlier?

Will

Back to linux.kernel | Previous | NextPrevious in thread | Next in thread | Find similar | Unroll thread


Thread

[PATCH] arm64: Fix the kernel panic() on QDF2400 platform Shanker Donthineni <shankerd@codeaurora.org> - 2017-02-23 04:30 +0100
  Re: [PATCH] arm64: Fix the kernel panic() on QDF2400 platform Will Deacon <will.deacon@arm.com> - 2017-02-23 15:50 +0100
    Re: [PATCH] arm64: Fix the kernel panic() on QDF2400 platform Timur Tabi <timur@codeaurora.org> - 2017-02-23 20:30 +0100
  Re: arm64: Fix the kernel panic() on QDF2400 platform Manoj Iyer <manoj.iyer@canonical.com> - 2017-02-23 19:20 +0100

csiph-web