Re: netfilter: nft_ct: add zone id set support

Path	csiph.com!1.us.feeder.erje.net!2.us.feeder.erje.net!feeder.erje.net!1.eu.feeder.erje.net!weretis.net!feeder4.news.weretis.net!news.unit0.net!news.panservice.it!bofh.it!news.nic.it!robomod
From	Florian Westphal <fw@strlen.de>
Newsgroups	linux.kernel
Subject	Re: netfilter: nft_ct: add zone id set support
Date	Thu, 23 Feb 2017 12:50:02 +0100
Message-ID	<te04i-HT-9@gated-at.bofh.it> (permalink)
References	<tdYlP-7YH-11@gated-at.bofh.it> <tdYlP-7YH-9@gated-at.bofh.it>
X-Original-To	Geert Uytterhoeven <geert@linux-m68k.org>
MIME-Version	1.0
Content-Type	text/plain; charset=us-ascii
Content-Disposition	inline
User-Agent	Mutt/1.5.23 (2014-03-12)
Sender	robomod@news.nic.it
List-ID	<linux-kernel.vger.kernel.org>
X-Mailing-List	linux-kernel@vger.kernel.org
Approved	robomod@news.nic.it
Lines	27
Organization	linux.* mail to news gateway
X-Original-Cc	Florian Westphal <fw@strlen.de>, Pablo Neira Ayuso <pablo@netfilter.org>, Jozsef Kadlecsik <kadlec@blackhole.kfki.hu>, "David S. Miller" <davem@davemloft.net>, netfilter-devel@vger.kernel.org, "netdev@vger.kernel.org" <netdev@vger.kernel.org>, Linux Kernel Mailing List <linux-kernel@vger.kernel.org>
X-Original-Date	Thu, 23 Feb 2017 12:34:35 +0100
X-Original-Message-ID	<20170223113435.GF11144@breakpoint.cc>
X-Original-References	<20170222190219.EC87B661B65@gitolite.kernel.org> <CAMuHMdUJ=2+9ko0KEU7rX3rb7vghNj3Xc-HSLSK=-kqQ+CZM6w@mail.gmail.com>
X-Original-Sender	linux-kernel-owner@vger.kernel.org
Xref	csiph.com linux.kernel:1586841

Show key headers only | View raw

Geert Uytterhoeven <geert@linux-m68k.org> wrote:
> On Wed, Feb 22, 2017 at 8:02 PM, Linux Kernel Mailing List
> <linux-kernel@vger.kernel.org> wrote:
> > Web:        https://git.kernel.org/torvalds/c/edee4f1e92458299505ff007733f676b00c516a1
> > Commit:     edee4f1e92458299505ff007733f676b00c516a1
> > Parent:     5c178d81b69f08ca3195427a6ea9a46d9af23127
> > Refname:    refs/heads/master
> > Author:     Florian Westphal <fw@strlen.de>
> > AuthorDate: Fri Feb 3 13:35:50 2017 +0100
> > Committer:  Pablo Neira Ayuso <pablo@netfilter.org>
> > CommitDate: Wed Feb 8 14:16:23 2017 +0100
> >
> Unlike for the other cases of the switch statement, "len" is not initialized
> here...
> 
> > +               break;
> >         priv->sreg = nft_parse_register(tb[NFTA_CT_SREG]);
> >         err = nft_validate_register_load(priv->sreg, len);
> 
> ... and used here, which may lead to spurious failures of
> nft_validate_register_load().

Yes, Dan reported this and a patch is queued at
http://patchwork.ozlabs.org/patch/727573/

Pablo, any reason why this is still waiting?
Do you want me to run more tests?

Back to linux.kernel | Previous | Next — Previous in thread | Find similar | Unroll thread

Thread

Re: netfilter: nft_ct: add zone id set support Geert Uytterhoeven <geert@linux-m68k.org> - 2017-02-23 11:00 +0100
  Re: netfilter: nft_ct: add zone id set support Pablo Neira Ayuso <pablo@netfilter.org> - 2017-02-23 12:50 +0100
    Re: netfilter: nft_ct: add zone id set support Florian Westphal <fw@strlen.de> - 2017-02-23 13:00 +0100
  Re: netfilter: nft_ct: add zone id set support Florian Westphal <fw@strlen.de> - 2017-02-23 12:50 +0100

csiph-web