Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]


Groups > linux.kernel > #1585959

Re: [PATCH 1/2] Correct function definition for C++

From Greg KH <greg@kroah.com>
Newsgroups linux.kernel
Subject Re: [PATCH 1/2] Correct function definition for C++
Date 2017-02-22 08:20 +0100
Message-ID <tdznr-6r0-9@gated-at.bofh.it> (permalink)
References <tdkHM-4r9-27@gated-at.bofh.it>
Organization linux.* mail to news gateway

Show all headers | View raw


On Tue, Feb 21, 2017 at 04:24:04PM +0100, Joakim Tjernlund wrote:
> C++ does does not like the extra extern before asmlinkage, remove it.
> 
> Signed-off-by: Joakim Tjernlund <joakim.tjernlund@infinera.com>
> ---
>  include/linux/printk.h | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/include/linux/printk.h b/include/linux/printk.h
> index 3472cc6..be823f5 100644
> --- a/include/linux/printk.h
> +++ b/include/linux/printk.h


Why are you building this file with a C++ compiler?

Also, this is not the correct way to submit patches for inclusion in the
stable kernel tree.  Please read Documentation/stable_kernel_rules.txt
for how to do this properly.

thanks,

greg k-h

Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread


Thread

[PATCH 1/2] Correct function definition for C++ Joakim Tjernlund <joakim.tjernlund@infinera.com> - 2017-02-21 16:40 +0100
  [PATCH 2/2] compiler.h: fix C++ uninitialized const issue Joakim Tjernlund <joakim.tjernlund@infinera.com> - 2017-02-21 16:40 +0100
  Re: [PATCH 1/2] Correct function definition for C++ Greg KH <greg@kroah.com> - 2017-02-22 08:20 +0100
    Re: [PATCH 1/2] Correct function definition for C++ "greg@kroah.com" <greg@kroah.com> - 2017-02-22 14:10 +0100
      Re: [PATCH 1/2] Correct function definition for C++ "greg@kroah.com" <greg@kroah.com> - 2017-02-22 15:30 +0100
    Re: [PATCH 1/2] Correct function definition for C++ Thomas Backlund <tmb@mageia.org> - 2017-03-01 02:00 +0100

csiph-web