Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1585726

Re: [PATCH 2/4] x86: convert threshold_bank.cpus from atomic_t to refcount_t

Show all headers | View raw

On Mon, Feb 20, 2017 at 3:17 AM, Borislav Petkov <bp@alien8.de> wrote:
> On Mon, Feb 20, 2017 at 01:06:19PM +0200, Elena Reshetova wrote:
>> refcount_t type and corresponding API should be
>> used instead of atomic_t when the variable is used as
>> a reference counter. This allows to avoid accidental
>> refcounter overflows that might lead to use-after-free
>> situations.
>>
>> Signed-off-by: Elena Reshetova <elena.reshetova@intel.com>
>> Signed-off-by: Hans Liljestrand <ishkamiel@gmail.com>
>> Signed-off-by: Kees Cook <keescook@chromium.org>
>> Signed-off-by: David Windsor <dwindsor@gmail.com>
>
> That SOB chain tells me that you wrote the patch and Hans, Kees and
> David handled it in some way and the last one - David - is sending it to
> me. It doesn't look like that though.

Perhaps the least inaccurate form of this might be:


Inspired by atomic protections in PaX/grsecurity.

Suggested-by: Kees Cook <keescook@chromium.org>
Reviewed-by: David Windsor <dwindsor@gmail.com>
Reviewed-by: Hans Liljestrand <ishkamiel@gmail.com>
Signed-off-by: Elena Reshetova <elena.reshetova@intel.com>


As this is something I'd suggested we implement based on the work in
PaX/grsecurity, David took the first (and continuing) stab at
conversions, Hans did more, and Elena has been doing even more along
with the heavy-lifting of keeping the series organized. That way the
first SoB is still the author, the last SoB is still the email sender,
and everyone's name is mentioned.

Or just:


Inspired by atomic protections in PaX/grsecurity, based on work from
David Windsor, Hans Liljestrand, and myself.

Signed-off-by: Elena Reshetova <elena.reshetova@intel.com>


I'm not picky -- I just want to see the conversion to refcount_t
happen, and everyone in Elena's SoB list has done work on it...

-Kees

-- 
Kees Cook
Pixel Security

Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread

Thread

[PATCH 0/4] arch subsystem refcounter conversions Elena Reshetova <elena.reshetova@intel.com> - 2017-02-20 12:10 +0100
  [PATCH 3/4] sparc: convert mdesc_handle.refcnt from atomic_t to refcount_t Elena Reshetova <elena.reshetova@intel.com> - 2017-02-20 12:10 +0100
    Re: [PATCH 3/4] sparc: convert mdesc_handle.refcnt from atomic_t  to refcount_t David Miller <davem@davemloft.net> - 2017-02-20 16:00 +0100
  [PATCH 1/4] s390: convert debug_info.ref_count from atomic_t to refcount_t Elena Reshetova <elena.reshetova@intel.com> - 2017-02-20 12:10 +0100
    Re: [PATCH 1/4] s390: convert debug_info.ref_count from atomic_t to  refcount_t Heiko Carstens <heiko.carstens@de.ibm.com> - 2017-02-20 14:30 +0100
      RE: [PATCH 1/4] s390: convert debug_info.ref_count from atomic_t to  refcount_t "Reshetova, Elena" <elena.reshetova@intel.com> - 2017-02-20 14:40 +0100
      Re: [PATCH 1/4] s390: convert debug_info.ref_count from atomic_t to  refcount_t Heiko Carstens <heiko.carstens@de.ibm.com> - 2017-02-20 14:40 +0100
      Re: [PATCH 1/4] s390: convert debug_info.ref_count from atomic_t to  refcount_t Peter Zijlstra <peterz@infradead.org> - 2017-02-20 14:40 +0100
  [PATCH 4/4] kvm: convert kvm.users_count from atomic_t to refcount_t Elena Reshetova <elena.reshetova@intel.com> - 2017-02-20 12:10 +0100
    Re: [PATCH 4/4] kvm: convert kvm.users_count from atomic_t to  refcount_t Paolo Bonzini <pbonzini@redhat.com> - 2017-02-20 12:40 +0100
      RE: [PATCH 4/4] kvm: convert kvm.users_count from atomic_t to  refcount_t "Reshetova, Elena" <elena.reshetova@intel.com> - 2017-02-20 13:30 +0100
  [PATCH 2/4] x86: convert threshold_bank.cpus from atomic_t to refcount_t Elena Reshetova <elena.reshetova@intel.com> - 2017-02-20 12:10 +0100
    Re: [PATCH 2/4] x86: convert threshold_bank.cpus from atomic_t to  refcount_t Borislav Petkov <bp@alien8.de> - 2017-02-20 12:30 +0100
      RE: [PATCH 2/4] x86: convert threshold_bank.cpus from atomic_t to  refcount_t "Reshetova, Elena" <elena.reshetova@intel.com> - 2017-02-20 13:30 +0100
        Re: [PATCH 2/4] x86: convert threshold_bank.cpus from atomic_t to  refcount_t Borislav Petkov <bp@alien8.de> - 2017-02-20 13:40 +0100
      Re: [PATCH 2/4] x86: convert threshold_bank.cpus from atomic_t to refcount_t Kees Cook <keescook@chromium.org> - 2017-02-21 21:50 +0100
        Re: [PATCH 2/4] x86: convert threshold_bank.cpus from atomic_t to  refcount_t Borislav Petkov <bp@alien8.de> - 2017-02-22 10:40 +0100

csiph-web