Re: [PATCH v2] x86/mce: Don't participate in rendezvous process once nmi_shootdown_cpus() was made

From	Borislav Petkov <bp@alien8.de>
Newsgroups	linux.kernel
Subject	Re: [PATCH v2] x86/mce: Don't participate in rendezvous process once nmi_shootdown_cpus() was made
Date	2017-02-21 18:30 +0100
Message-ID	<tdmqd-5F2-13@gated-at.bofh.it> (permalink)
References	<tcPkC-X2-3@gated-at.bofh.it> <tcUaB-3XL-9@gated-at.bofh.it> <tdhTA-2y5-3@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw

On Tue, Feb 21, 2017 at 08:37:21PM +0800, Xunlei Pang wrote:
> -    /* If this CPU is offline, just bail out. */
> -    if (cpu_is_offline(smp_processor_id())) {
> +    /*
> +     * Cases to bail out to avoid rendezvous process timeout:
> +     * 1)If crashing_cpu was set, e.g. entering kdump,
> +     *   we need to skip cpus remaining in 1st kernel.
> +     * 2)If this CPU is offline.
> +     */
> +    if (crashing_cpu != -1 ||
> +        cpu_is_offline(smp_processor_id())) {

You're still not letting the crashing_cpu enter the #MC handler. You
need to handle the MCE no matter how short the window is.

-- 
Regards/Gruss,
    Boris.

Good mailing practices for 400: avoid top-posting and trim the reply.

Back to linux.kernel | Previous | Next — Previous in thread | Find similar | Unroll thread

Thread

[PATCH v2] x86/mce: Don't participate in rendezvous process once nmi_shootdown_cpus() was made Xunlei Pang <xlpang@redhat.com> - 2017-02-20 07:10 +0100
  Re: [PATCH v2] x86/mce: Don't participate in rendezvous process once  nmi_shootdown_cpus() was made Borislav Petkov <bp@alien8.de> - 2017-02-20 12:20 +0100
    Re: [PATCH v2] x86/mce: Don't participate in rendezvous process once  nmi_shootdown_cpus() was made Xunlei Pang <xpang@redhat.com> - 2017-02-20 14:30 +0100
      Re: [PATCH v2] x86/mce: Don't participate in rendezvous process once  nmi_shootdown_cpus() was made Borislav Petkov <bp@alien8.de> - 2017-02-20 21:30 +0100
        Re: [PATCH v2] x86/mce: Don't participate in rendezvous process once  nmi_shootdown_cpus() was made Xunlei Pang <xpang@redhat.com> - 2017-02-21 02:30 +0100
          Re: [PATCH v2] x86/mce: Don't participate in rendezvous process once  nmi_shootdown_cpus() was made Borislav Petkov <bp@alien8.de> - 2017-02-21 09:50 +0100
      Re: [PATCH v2] x86/mce: Don't participate in rendezvous process once  nmi_shootdown_cpus() was made Xunlei Pang <xpang@redhat.com> - 2017-02-21 02:30 +0100
    Re: [PATCH v2] x86/mce: Don't participate in rendezvous process once  nmi_shootdown_cpus() was made Xunlei Pang <xpang@redhat.com> - 2017-02-21 13:40 +0100
      Re: [PATCH v2] x86/mce: Don't participate in rendezvous process once  nmi_shootdown_cpus() was made Borislav Petkov <bp@alien8.de> - 2017-02-21 18:30 +0100

csiph-web