Re: [bisection] b0119e87083 iommu: Introduce new 'struct iommu_device' ==> boom

From	Mike Galbraith <efault@gmx.de>
Newsgroups	linux.kernel
Subject	Re: [bisection] b0119e87083 iommu: Introduce new 'struct iommu_device' ==> boom
Date	2017-02-21 18:10 +0100
Message-ID	<tdm6R-5vv-1@gated-at.bofh.it> (permalink)
References	<tdk55-3Wc-59@gated-at.bofh.it> <tdkoq-4k1-31@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw

On Tue, 2017-02-21 at 16:19 +0100, Joerg Roedel wrote:
> Hi Mike,
> 
> thanks for the report, this didn't trigger in my local testing here.
> Loosk like I need to test without intel_iommu=on too :/
> 
> Anyway, can you check whether the attached patch helps?

Yup, boots.

> diff --git a/drivers/iommu/dmar.c b/drivers/iommu/dmar.c
> index d9c0decfc91a..a74fec8d266a 100644
> --- a/drivers/iommu/dmar.c
> +++ b/drivers/iommu/dmar.c
> @@ -1108,8 +1108,10 @@ static int alloc_iommu(struct dmar_drhd_unit
> *drhd)
>  
>  static void free_iommu(struct intel_iommu *iommu)
>  {
> -	iommu_device_sysfs_remove(&iommu->iommu);
> -	iommu_device_unregister(&iommu->iommu);
> +	if (intel_iommu_enabled) {
> +		iommu_device_sysfs_remove(&iommu->iommu);
> +		iommu_device_unregister(&iommu->iommu);
> +	}
>  
>  	if (iommu->irq) {
>  		if (iommu->pr_irq) {

Back to linux.kernel | Previous | Next — Previous in thread | Find similar | Unroll thread

Thread

[bisection] b0119e87083  iommu: Introduce new 'struct iommu_device'  ==> boom Mike Galbraith <efault@gmx.de> - 2017-02-21 16:00 +0100
  Re: [bisection] b0119e87083  iommu: Introduce new 'struct  iommu_device' ==> boom Joerg Roedel <jroedel@suse.de> - 2017-02-21 16:20 +0100
    Re: [bisection] b0119e87083  iommu: Introduce new 'struct  iommu_device' ==> boom Mike Galbraith <efault@gmx.de> - 2017-02-21 18:10 +0100

csiph-web