Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]


Groups > linux.kernel > #1585481

Re: [RFC v2 1/1] shiftfs: uid/gid shifting bind mount

From Vivek Goyal <vgoyal@redhat.com>
Newsgroups linux.kernel
Subject Re: [RFC v2 1/1] shiftfs: uid/gid shifting bind mount
Date 2017-02-21 17:10 +0100
Message-ID <tdlaO-4Vr-23@gated-at.bofh.it> (permalink)
References <td6Ot-3u9-3@gated-at.bofh.it> <td6Ot-3u9-5@gated-at.bofh.it>
Organization linux.* mail to news gateway

Show all headers | View raw


On Mon, Feb 20, 2017 at 04:47:05PM -0800, James Bottomley wrote:

[..]
> +static struct dentry *shiftfs_lookup(struct inode *dir, struct dentry *dentry,
> +				     unsigned int flags)
> +{
> +	struct dentry *real = dir->i_private, *new;
> +	struct inode *reali = real->d_inode, *newi;

newi needs to be initialized to NULL. Otherwise if a file does not
exist, we try to call d_splice_alias() with uninitialized value of newi.

This crashes for the new file creation case.

Vivek

Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread


Thread

[RFC v2 0/1] shiftfs: uid/gid shifting filesystem (s_user_ns  version) James Bottomley <James.Bottomley@HansenPartnership.com> - 2017-02-21 01:50 +0100
  [RFC v2 1/1] shiftfs: uid/gid shifting bind mount James Bottomley <James.Bottomley@HansenPartnership.com> - 2017-02-21 01:50 +0100
    Re: [RFC v2 1/1] shiftfs: uid/gid shifting bind mount Vivek Goyal <vgoyal@redhat.com> - 2017-02-21 17:10 +0100
      Re: [RFC v2 1/1] shiftfs: uid/gid shifting bind mount James Bottomley <James.Bottomley@HansenPartnership.com> - 2017-02-21 23:30 +0100
        Re: [RFC v2 1/1] shiftfs: uid/gid shifting bind mount Vivek Goyal <vgoyal@redhat.com> - 2017-02-22 17:50 +0100

csiph-web