Re: [PATCH net-next v3 0/4] net: mvneta: improve rx/tx performance

From	Marcin Wojtas <mw@semihalf.com>
Newsgroups	linux.kernel
Subject	Re: [PATCH net-next v3 0/4] net: mvneta: improve rx/tx performance
Date	2017-02-21 17:40 +0100
Message-ID	<tdlDP-55Q-5@gated-at.bofh.it> (permalink)
References	<tcVJo-4Mr-17@gated-at.bofh.it> <tcX8t-5Nt-3@gated-at.bofh.it> <tdayJ-5YF-3@gated-at.bofh.it> <tdlku-4YS-19@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw

Hi Jisheng,

2017-02-21 17:16 GMT+01:00 David Miller <davem@davemloft.net>:
> From: Jisheng Zhang <jszhang@marvell.com>
> Date: Tue, 21 Feb 2017 12:37:40 +0800
>
>> Thanks for your review.
>>
>> The measurement is simple: record how much time we spent in mvneta_rx_swbm()
>> for receiving 1GB data, something as below:
>
> Please use a standard tool for measuring performance, rather than profiling
> the driver and trying to derive numbers that way.

If possible in your setup, I suggest pushing 64B (and other sizes)
packets uni or bidirectionally via 2 ports in L2 bridge mode. It's a
good stress test, you'd get some meaningful numbers (also check cpu
consumption with mpstat in the meantime).

Best regards,
Marcin

Thread

[PATCH net-next v3 0/4] net: mvneta: improve rx/tx performance Jisheng Zhang <jszhang@marvell.com> - 2017-02-20 14:00 +0100
  [PATCH net-next v3 3/4] net: mvneta: avoid reading from tx_desc as much as possible Jisheng Zhang <jszhang@marvell.com> - 2017-02-20 14:00 +0100
  [PATCH net-next v3 1/4] net: mvneta: avoid getting status from rx_desc as much as possible Jisheng Zhang <jszhang@marvell.com> - 2017-02-20 14:10 +0100
  [PATCH net-next v3 2/4] net: mvneta: avoid getting buf_phys_addr from rx_desc again Jisheng Zhang <jszhang@marvell.com> - 2017-02-20 14:10 +0100
  [PATCH net-next v3 4/4] net: mvneta: Use cacheable memory to store the rx buffer DMA address Jisheng Zhang <jszhang@marvell.com> - 2017-02-20 14:10 +0100
  Re: [PATCH net-next v3 0/4] net: mvneta: improve rx/tx performance Gregory CLEMENT <gregory.clement@free-electrons.com> - 2017-02-20 15:30 +0100
    Re: [PATCH net-next v3 0/4] net: mvneta: improve rx/tx performance Jisheng Zhang <jszhang@marvell.com> - 2017-02-21 05:50 +0100
      Re: [PATCH net-next v3 0/4] net: mvneta: improve rx/tx performance David Miller <davem@davemloft.net> - 2017-02-21 17:20 +0100
        Re: [PATCH net-next v3 0/4] net: mvneta: improve rx/tx performance Marcin Wojtas <mw@semihalf.com> - 2017-02-21 17:40 +0100
        Re: [PATCH net-next v3 0/4] net: mvneta: improve rx/tx performance Jisheng Zhang <jszhang@marvell.com> - 2017-02-24 13:10 +0100

csiph-web