Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1585382

Re: [PATCH] dma-buf: add support for compat ioctl

Show all headers | View raw

Hi Christian,

On 2017-02-21 14:59, Christian König wrote:
> Am 21.02.2017 um 14:21 schrieb Marek Szyprowski:
>> Add compat ioctl support to dma-buf. This lets one to use 
>> DMA_BUF_IOCTL_SYNC
>> ioctl from 32bit application on 64bit kernel. Data structures for 
>> both 32
>> and 64bit modes are same, so there is no need for additional translation
>> layer.
>
> Well I might be wrong, but IIRC compat_ioctl was just optional and if 
> not specified unlocked_ioctl was called instead.
>
> If that is true your patch wouldn't have any effect at all.

Well, then why I got -ENOTTY in the 32bit test app for this ioctl on 
64bit ARM64 kernel without this patch?

Best regards
-- 
Marek Szyprowski, PhD
Samsung R&D Institute Poland

Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread

Thread

[PATCH] dma-buf: add support for compat ioctl Marek Szyprowski <m.szyprowski@samsung.com> - 2017-02-21 14:30 +0100
  Re: [PATCH] dma-buf: add support for compat ioctl Christian König <deathsimple@vodafone.de> - 2017-02-21 15:00 +0100
    Re: [PATCH] dma-buf: add support for compat ioctl Marek Szyprowski <m.szyprowski@samsung.com> - 2017-02-21 15:40 +0100
      Re: [PATCH] dma-buf: add support for compat ioctl Marek Szyprowski <m.szyprowski@samsung.com> - 2017-02-21 16:00 +0100
        Re: [PATCH] dma-buf: add support for compat ioctl Christian König <deathsimple@vodafone.de> - 2017-02-21 16:10 +0100
          Re: [PATCH] dma-buf: add support for compat ioctl Daniel Vetter <daniel@ffwll.ch> - 2017-02-22 20:10 +0100
            Re: [PATCH] dma-buf: add support for compat ioctl Sumit Semwal <sumit.semwal@linaro.org> - 2017-02-23 07:50 +0100

csiph-web