Re: [PATCH 6/7] ARM: NOMMU: Set ARM_DMA_MEM_BUFFERABLE for M-class cpus

From	Robin Murphy <robin.murphy@arm.com>
Newsgroups	linux.kernel
Subject	Re: [PATCH 6/7] ARM: NOMMU: Set ARM_DMA_MEM_BUFFERABLE for M-class cpus
Date	2017-02-21 14:00 +0100
Message-ID	<tdicV-2HY-1@gated-at.bofh.it> (permalink)
References	<tb4H8-706-5@gated-at.bofh.it> <tb4H8-706-15@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw

On 15/02/17 09:59, Vladimir Murzin wrote:
> Now, we have dedicated non-cacheable region for consistent DMA
> operations. However, that region can still be marked as bufferable by
> MPU, so it'd be safer to have barriers by default.

Makes sense - plenty of cases want their DMA buffers to still be
write-combining (e.g. framebuffers have already been mentioned here),
for which strongly-ordered mappings won't do. Plus you don't exactly
have a choice if you've no MPU and have fixed Normal attributes for your
RAM region.

Reviewed-by: Robin Murphy <robin.murphy@arm.com>

> Tested-by: Benjamin Gaignard <benjamin.gaignard@linaro.org>
> Tested-by: Andras Szemzo <sza@esh.hu>
> Tested-by: Alexandre TORGUE <alexandre.torgue@st.com>
> Signed-off-by: Vladimir Murzin <vladimir.murzin@arm.com>
> ---
>  arch/arm/mm/Kconfig | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/arch/arm/mm/Kconfig b/arch/arm/mm/Kconfig
> index 0b79f12..64a1465c 100644
> --- a/arch/arm/mm/Kconfig
> +++ b/arch/arm/mm/Kconfig
> @@ -1029,7 +1029,7 @@ config ARM_L1_CACHE_SHIFT
>  
>  config ARM_DMA_MEM_BUFFERABLE
>  	bool "Use non-cacheable memory for DMA" if (CPU_V6 || CPU_V6K) && !CPU_V7
> -	default y if CPU_V6 || CPU_V6K || CPU_V7
> +	default y if CPU_V6 || CPU_V6K || CPU_V7 || CPU_V7M
>  	help
>  	  Historically, the kernel has used strongly ordered mappings to
>  	  provide DMA coherent memory.  With the advent of ARMv7, mapping
>

Thread

[PATCH 0/7] ARM: Fix dma_alloc_coherent() and friends for NOMMU Vladimir Murzin <vladimir.murzin@arm.com> - 2017-02-15 11:10 +0100
  [PATCH 6/7] ARM: NOMMU: Set ARM_DMA_MEM_BUFFERABLE for M-class cpus Vladimir Murzin <vladimir.murzin@arm.com> - 2017-02-15 11:10 +0100
    Re: [PATCH 6/7] ARM: NOMMU: Set ARM_DMA_MEM_BUFFERABLE for M-class  cpus Robin Murphy <robin.murphy@arm.com> - 2017-02-21 14:00 +0100
      Re: [PATCH 6/7] ARM: NOMMU: Set ARM_DMA_MEM_BUFFERABLE for M-class  cpus Vladimir Murzin <vladimir.murzin@arm.com> - 2017-02-21 14:10 +0100
  [PATCH 5/7] ARM: NOMMU: Introduce dma operations for noMMU Vladimir Murzin <vladimir.murzin@arm.com> - 2017-02-15 11:10 +0100
  Re: [PATCH 0/7] ARM: Fix dma_alloc_coherent() and friends for NOMMU Vladimir Murzin <vladimir.murzin@arm.com> - 2017-02-21 11:50 +0100
    Re: [PATCH 0/7] ARM: Fix dma_alloc_coherent() and friends for NOMMU Robin Murphy <robin.murphy@arm.com> - 2017-02-21 13:20 +0100
      Re: [PATCH 0/7] ARM: Fix dma_alloc_coherent() and friends for NOMMU Vladimir Murzin <vladimir.murzin@arm.com> - 2017-02-21 13:30 +0100

csiph-web