Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]
Groups > linux.kernel > #1586738
| From | Dmitry Torokhov <dmitry.torokhov@gmail.com> |
|---|---|
| Newsgroups | linux.kernel |
| Subject | Re: [PATCH 2/4] input:touchscreen:ad7879-spi.c: Remove bits_per_word = 16 enforcement |
| Date | 2017-02-23 09:50 +0100 |
| Message-ID | <tdXg5-7i8-1@gated-at.bofh.it> (permalink) |
| References | <tdXg5-7i8-3@gated-at.bofh.it> <tdXg5-7i8-5@gated-at.bofh.it> |
| Organization | linux.* mail to news gateway |
On Wed, Feb 22, 2017 at 05:14:36PM +0100, michael.hennerich@analog.com wrote:
> From: Michael Hennerich <michael.hennerich@analog.com>
>
> Using regmap this is no longer required.
>
> Signed-off-by: Michael Hennerich <michael.hennerich@analog.com>
This gave me warnings about unused "err" variable, I removed it and
applied, thank you.
> ---
> drivers/input/touchscreen/ad7879-spi.c | 7 -------
> 1 file changed, 7 deletions(-)
>
> diff --git a/drivers/input/touchscreen/ad7879-spi.c b/drivers/input/touchscreen/ad7879-spi.c
> index b995891..904a2c2 100644
> --- a/drivers/input/touchscreen/ad7879-spi.c
> +++ b/drivers/input/touchscreen/ad7879-spi.c
> @@ -42,13 +42,6 @@ static int ad7879_spi_probe(struct spi_device *spi)
> return -EINVAL;
> }
>
> - spi->bits_per_word = 16;
> - err = spi_setup(spi);
> - if (err) {
> - dev_dbg(&spi->dev, "spi master doesn't support 16 bits/word\n");
> - return err;
> - }
> -
> regmap = devm_regmap_init_spi(spi, &ad7879_spi_regmap_config);
> if (IS_ERR(regmap))
> return PTR_ERR(regmap);
> --
> 2.7.4
>
--
Dmitry
Back to linux.kernel | Previous | Next | Find similar | Unroll thread
Re: [PATCH 2/4] input:touchscreen:ad7879-spi.c: Remove bits_per_word = 16 enforcement Dmitry Torokhov <dmitry.torokhov@gmail.com> - 2017-02-23 09:50 +0100
csiph-web