Re: lib: Introduce priority array area manager

Path	csiph.com!news.mixmin.net!news.unit0.net!news.panservice.it!bofh.it!news.nic.it!robomod
From	Geert Uytterhoeven <geert@linux-m68k.org>
Newsgroups	linux.kernel
Subject	Re: lib: Introduce priority array area manager
Date	Thu, 23 Feb 2017 10:30:02 +0100
Message-ID	<tdXSO-7Pd-9@gated-at.bofh.it> (permalink)
References	<tdWtH-6D3-7@gated-at.bofh.it> <tdWtH-6D3-5@gated-at.bofh.it> <tdX6q-7c9-17@gated-at.bofh.it>
X-Original-To	Jiri Pirko <jiri@resnulli.us>
Dkim-Signature	v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:sender:in-reply-to:references:from:date:message-id :subject:to:cc; bh=iX35MIclzLz87QxtJBiTfWiMhyBsQFX4YMO6qtNDk1o=; b=D086w2IGPxdp1WW+rH4nm3bHQLuQ49xQIEhwh15LRr3xfDZqevGjjc6CvcZzl4MLki Bt50yYdu9+GvWtYdBo4mUGsNIGvI2Xj1keIsvNy8iAqcZeIH8bNXyDUdDjnSomcpcivz aJe5KbeqFb0U+ZlxwvBgG8wJOnK5EWNn8LNkD+10WYbFUA906cCAFTbmI8P3slGPoUxt 8BAJTXw5HkW5CuhE9/cYt02pTEPixm0TYmOOvVcC1jPK+d6gd0Jm6WY/mAdztRQlexpT niBJ8v9v5L7R8cy0Tt0k3GPGpQO7X1nNUQm3lB0rnmg88oO5VO+ugVg99cStpaEBu1pj DlHA==
X-Google-Dkim-Signature	v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:sender:in-reply-to:references:from :date:message-id:subject:to:cc; bh=iX35MIclzLz87QxtJBiTfWiMhyBsQFX4YMO6qtNDk1o=; b=dGgyBtq4ApkpiND6PGDdIecMqVEUeLgHmhuqA8FiVF58X58OsY+T5sKZqR8e23ABcs t9ojB+JcoMYBJpbqbKe6HFGqLJhwwgrCe0YRdyBWx0De9H2j065G2ftMO/7Xp234SqvL yMhWiSSu/zfggPgp314fBs4vfhgD0OSFJgCxXKW/Fvsko6NT9zlDQpyHMJydMAiGY5Wi 3SxiV7hiBfxnRoF5l3d6m220eQPHmoR9EzS3dDtrLQJzmoN/LnK63YINtwRzCBmMPM2a Sr8Hs5Cm1OUIsNB4MoE5h1qX1ugLjr8LQN0Z2cxPDzARNwPb8oE7ibxXpjeXkgyv6bND ylGA==
X-Gm-Message-State	AMke39kWZvhwijHgRw7fT+DPxSBJzy4LzH4NhYhSz1Lpl9aMa5pLbsFLu0UFeuG9LPWRGPpg/imF+6BQqCWpyQ==
X-Received	by 10.107.189.197 with SMTP id n188mr31202123iof.88.1487841743175; Thu, 23 Feb 2017 01:22:23 -0800 (PST)
MIME-Version	1.0
X-Google-Sender-Auth	yI44BP9JuqMHKgMo3XBvRmB7PiU
Content-Type	text/plain; charset=UTF-8
Sender	robomod@news.nic.it
List-ID	<linux-kernel.vger.kernel.org>
X-Mailing-List	linux-kernel@vger.kernel.org
Approved	robomod@news.nic.it
Lines	73
Organization	linux.* mail to news gateway
X-Original-Cc	Jiri Pirko <jiri@mellanox.com>, "netdev@vger.kernel.org" <netdev@vger.kernel.org>, Linux Kernel Mailing List <linux-kernel@vger.kernel.org>
X-Original-Date	Thu, 23 Feb 2017 10:22:22 +0100
X-Original-Message-ID	<CAMuHMdV4-xfKyBiBU2GaR42MA_5LjspF-wykN=ADgEdF6X+wWg@mail.gmail.com>
X-Original-References	<20170222190204.878696619DE@gitolite.kernel.org> <CAMuHMdXR5QZrN1NMkZq_jSo0cRMqMJ6m5q-8C3pr1_NWKUZcqg@mail.gmail.com> <20170223083231.GA2699@nanopsycho>
X-Original-Sender	linux-kernel-owner@vger.kernel.org
Xref	csiph.com linux.kernel:1586775

Show key headers only | View raw

Hi Jiri,

On Thu, Feb 23, 2017 at 9:32 AM, Jiri Pirko <jiri@resnulli.us> wrote:
> Thu, Feb 23, 2017 at 08:56:26AM CET, geert@linux-m68k.org wrote:
>>On Wed, Feb 22, 2017 at 8:02 PM, Linux Kernel Mailing List
>><linux-kernel@vger.kernel.org> wrote:
>>> Web:        https://git.kernel.org/torvalds/c/44091d29f2075972aede47ef17e1e70db3d51190
>>> Commit:     44091d29f2075972aede47ef17e1e70db3d51190
>>> Parent:     b862815c3ee7b49ec20a9ab25da55a5f0bcbb95e
>>> Refname:    refs/heads/master
>>> Author:     Jiri Pirko <jiri@mellanox.com>
>>> AuthorDate: Fri Feb 3 10:29:06 2017 +0100
>>> Committer:  David S. Miller <davem@davemloft.net>
>>> CommitDate: Fri Feb 3 16:35:42 2017 -0500
>>>
>>>     lib: Introduce priority array area manager
>>>
>>>     This introduces a infrastructure for management of linear priority
>>>     areas. Priority order in an array matters, however order of items inside
>>>     a priority group does not matter.
>>>
>>>     As an initial implementation, L-sort algorithm is used. It is quite
>>>     trivial. More advanced algorithm called P-sort will be introduced as a
>>>     follow-up. The infrastructure is prepared for other algos.
>>>
>>>     Alongside this, a testing module is introduced as well.
>>>
>>>     Signed-off-by: Jiri Pirko <jiri@mellanox.com>
>>>     Signed-off-by: David S. Miller <davem@davemloft.net>
>>
>>> --- a/lib/Kconfig
>>> +++ b/lib/Kconfig
>>> @@ -550,4 +550,7 @@ config STACKDEPOT
>>>  config SBITMAP
>>>         bool
>>>
>>> +config PARMAN
>>> +       tristate "parman"
>>
>>| parman (PARMAN) [N/m/y] (NEW) ?
>>|
>>| There is no help available for this option.
>>
>>Can you please add a description for this option?
>>Or drop the "parman" string if this is always selected by its kernel users, and
>>never intended to be enabled by the end user.
>
> I did it in the same way other similar lib dependencies do that. Does
> not make sense to have separate description for this, cause this is
> always only a dependency of a kernel user.

OK, so the user should not be asked about it...

> You suggeste to 'drop the "parman" string'. What do you mean by that
> exactly?

... and

-       tristate "parman"
+       tristate

should do the trick.

Gr{oetje,eeting}s,

                        Geert

--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org

In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
                                -- Linus Torvalds

Back to linux.kernel | Previous | Next — Previous in thread | Find similar | Unroll thread

Thread

Re: lib: Introduce priority array area manager Geert Uytterhoeven <geert@linux-m68k.org> - 2017-02-23 09:00 +0100
  Re: lib: Introduce priority array area manager Jiri Pirko <jiri@resnulli.us> - 2017-02-23 09:40 +0100
    Re: lib: Introduce priority array area manager Jiri Pirko <jiri@resnulli.us> - 2017-02-23 10:30 +0100
    Re: lib: Introduce priority array area manager Geert Uytterhoeven <geert@linux-m68k.org> - 2017-02-23 10:30 +0100

csiph-web