Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1586637

Re: [PATCH] powerpc: Remove leftover cputime_to_nsecs call causing build error

Show all headers | View raw

On Thu, Feb 23, 2017 at 08:34:15AM +1100, Michael Ellerman wrote:
> Frederic Weisbecker <fweisbec@gmail.com> writes:
> 
> > This type conversion is a leftover that got ignored during the kcpustat
> > conversion to nanosecs, resulting in build breakage with config having
> > CONFIG_NO_HZ_FULL=y.
> >
> > 	arch/powerpc/kernel/time.c: In function 'running_clock':
> > 	arch/powerpc/kernel/time.c:712:2: error: implicit declaration of function 'cputime_to_nsecs' [-Werror=implicit-function-declaration]
> > 	  return local_clock() - cputime_to_nsecs(kcpustat_this_cpu->cpustat[CPUTIME_STEAL]);
> >
> > All we need is to remove it.
> >
> > Reported-by: Abdul Haleem <abdhalee@linux.vnet.ibm.com>
> > Cc: Michael Ellerman <mpe@ellerman.id.au>
> > Cc: Benjamin Herrenschmidt <benh@kernel.crashing.org>
> > Cc: Paul Mackerras <paulus@samba.org>
> > Cc: Oliver O'Halloran <oohall@gmail.com>
> > Cc: linuxppc-dev@lists.ozlabs.org
> > Signed-off-by: Frederic Weisbecker <fweisbec@gmail.com>
> 
> LGTM.
> 
> Acked-by: Michael Ellerman <mpe@ellerman.id.au>
> 
> 
> Are you going to send this to Linus, or should I?

I would prefer you send it to Linus if you don't mind.

The fate of a powerpc patch sent by me directly to Linus is
anything but predictable :o)

Thanks.

Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread

Thread

[PATCH] powerpc: Remove leftover cputime_to_nsecs call causing build error Frederic Weisbecker <fweisbec@gmail.com> - 2017-02-21 16:20 +0100
  Re: [PATCH] powerpc: Remove leftover cputime_to_nsecs call causing build error Michael Ellerman <mpe@ellerman.id.au> - 2017-02-22 22:40 +0100
    Re: [PATCH] powerpc: Remove leftover cputime_to_nsecs call causing  build error Frederic Weisbecker <fweisbec@gmail.com> - 2017-02-23 05:10 +0100
  Re: powerpc: Remove leftover cputime_to_nsecs call causing build error Michael Ellerman <patch-notifications@ellerman.id.au> - 2017-02-27 11:40 +0100

csiph-web