Re: [PATCH] uapi: fix linux/kexec.h userspace compilation errors

Path	csiph.com!aioe.org!news.servidellagleba.it!bofh.it!news.nic.it!robomod
From	"Dmitry V. Levin" <ldv@altlinux.org>
Newsgroups	linux.kernel
Subject	Re: [PATCH] uapi: fix linux/kexec.h userspace compilation errors
Date	Thu, 23 Feb 2017 03:20:01 +0100
Message-ID	<tdRaF-2LC-7@gated-at.bofh.it> (permalink)
References	<tdNTs-eQ-3@gated-at.bofh.it> <tdQHD-2lQ-9@gated-at.bofh.it>
X-Original-To	"Eric W. Biederman" <ebiederm@xmission.com>
MIME-Version	1.0
Content-Type	multipart/signed; micalg=x-unknown; protocol="application/pgp-signature"; boundary="Kj7319i9nmIyA2yE"
Content-Disposition	inline
Sender	robomod@news.nic.it
List-ID	<linux-kernel.vger.kernel.org>
X-Mailing-List	linux-kernel@vger.kernel.org
Approved	robomod@news.nic.it
Lines	58
Organization	linux.* mail to news gateway
X-Original-Cc	kexec@lists.infradead.org, linux-kernel@vger.kernel.org
X-Original-Date	Thu, 23 Feb 2017 05:07:02 +0300
X-Original-Message-ID	<20170223020702.GA16308@altlinux.org>
X-Original-References	<20170222224646.GC14311@altlinux.org> <87h93l3cwl.fsf@xmission.com>
X-Original-Sender	linux-kernel-owner@vger.kernel.org
Xref	csiph.com linux.kernel:1586611

Show key headers only | View raw

[Multipart message — attachments visible in raw view] - view raw

On Thu, Feb 23, 2017 at 02:37:46PM +1300, Eric W. Biederman wrote:
> "Dmitry V. Levin" <ldv@altlinux.org> writes:
> 
> > Include <stddef.h> (guarded by #ifndef __KERNEL__) to fix the following
> > linux/kexec.h userspace compilation errors:
> >
> > /usr/include/linux/kexec.h:53:2: error: unknown type name 'size_t'
> >   size_t bufsz;
> > /usr/include/linux/kexec.h:55:2: error: unknown type name 'size_t'
> >   size_t memsz;
> 
> Were these failures generated with a static checker?

Yes, with
gcc -S -o/dev/null -xc /dev/null -include /usr/include/linux/kexec.h

> What changed that you are seeing new failures in old essentially static
> headers?

Every uapi header file should be standalone, i.e. it must include,
directly or indirectly, every definition it uses, so that no user
should have to guess header dependencies.

It's not the first time I'm seeing this compilation error,
but now I've got some time to submit a fix.  Better late than never.

-- 
ldv

Back to linux.kernel | Previous | Next — Previous in thread | Find similar | Unroll thread

Thread

[PATCH] uapi: fix linux/kexec.h userspace compilation errors "Dmitry V. Levin" <ldv@altlinux.org> - 2017-02-22 23:50 +0100
  Re: [PATCH] uapi: fix linux/kexec.h userspace compilation errors ebiederm@xmission.com (Eric W. Biederman) - 2017-02-23 02:50 +0100
    Re: [PATCH] uapi: fix linux/kexec.h userspace compilation errors "Dmitry V. Levin" <ldv@altlinux.org> - 2017-02-23 03:20 +0100

csiph-web