Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1586081

Re: [PATCH 2/4] perf annotate: Align filename:linenr and more correct summary

From Namhyung Kim <namhyung@kernel.org>
Newsgroups linux.kernel
Subject Re: [PATCH 2/4] perf annotate: Align filename:linenr and more correct summary
Date 2017-02-22 12:30 +0100
Message-ID <tdDho-V3-17@gated-at.bofh.it> (permalink)
References <tdC1X-8u2-3@gated-at.bofh.it> <tdC1X-8u2-9@gated-at.bofh.it>
Organization linux.* mail to news gateway

Show all headers | View raw

On Wed, Feb 22, 2017 at 7:08 PM, Taeung Song <treeze.taeung@gmail.com> wrote:
> In the stdio interface, currently 'filename:linenr' infos
> are confusedly printed in the intervals of assembly code.
> So fix it.
>
> The cause was a 0.5% filter of if statement. After fixed,
> additionally summary of overhead per srcline is more correct.
>
> Before:
>
>     # perf annotate --stdio -l
>
>   Sorted summary for file /home/taeung/workspace/perf-test/test
>   ----------------------------------------------
>
>      36.57 test.c:38
>      28.72 test.c:37
>
>   ...
>
>    Percent |      Source code & Disassembly of test ...
>
>   ...
>
>       0.21 :        400816:       push   %rbp
>    test.c:26    1.86 :         400817:       mov    %rsp,%rbp
>       0.21 :        40081a:       mov    %edi,-0x24(%rbp)
>       0.21 :        40081d:       mov    %rsi,-0x30(%rbp)
>
> After:
>
>     # perf annotate --stdio -l
>
>   Sorted summary for file /home/taeung/workspace/perf-test/test
>   ----------------------------------------------
>
>      37.40 test.c:38
>      29.34 test.c:37
>
>   ...
>
>    Percent |      Source code & Disassembly of test ...
>
>   ...
>
>    test.c:26
>       0.21 :        400816:       push   %rbp
>       1.86 :        400817:       mov    %rsp,%rbp
>       0.21 :        40081a:       mov    %edi,-0x24(%rbp)
>       0.21 :        40081d:       mov    %rsi,-0x30(%rbp)

I guess it's just a problem of a missing newline..

Thanks,
Namhyung

Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread

Thread

[PATCH 2/4] perf annotate: Align filename:linenr and more correct summary Taeung Song <treeze.taeung@gmail.com> - 2017-02-22 11:10 +0100
  Re: [PATCH 2/4] perf annotate: Align filename:linenr and more correct summary Namhyung Kim <namhyung@kernel.org> - 2017-02-22 12:20 +0100
  Re: [PATCH 2/4] perf annotate: Align filename:linenr and more correct summary Namhyung Kim <namhyung@kernel.org> - 2017-02-22 12:30 +0100
    Re: [PATCH 2/4] perf annotate: Align filename:linenr and more correct  summary Taeung Song <treeze.taeung@gmail.com> - 2017-02-22 17:40 +0100

csiph-web