Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]
Groups > linux.kernel > #1586052
| Path | csiph.com!1.us.feeder.erje.net!2.us.feeder.erje.net!feeder.erje.net!1.eu.feeder.erje.net!weretis.net!feeder4.news.weretis.net!news.unit0.net!news.panservice.it!bofh.it!news.nic.it!robomod |
|---|---|
| From | Arnd Bergmann <arnd@arndb.de> |
| Newsgroups | linux.kernel |
| Subject | [PATCH, RESEND] usb: gadget: udc: atmel: fix debug output |
| Date | Wed, 22 Feb 2017 11:40:02 +0100 |
| Message-ID | <tdCv0-eA-7@gated-at.bofh.it> (permalink) |
| X-Original-To | Felipe Balbi <balbi@kernel.org>, Greg Kroah-Hartman <gregkh@linuxfoundation.org> |
| X-Mailer | git-send-email 2.9.0 |
| X-Provags-ID | V03:K0:SLmMKYg5V7g8mG+WPrjrmlCbvZiCWzDY5Dxz7hXA1PR6DG/aqha T7DwV7EqRKt8SWMbMtoa2jcSDkASPRLO/bBT3635dqSOUgeiMr+sN970Oh58CVt6z4QVEdN hDan3O4FVjzJVVwzWBEUhtnXlh7C/IlqvBiTLmQjWBBaWFBIxXToRqFS1uV0wlxVR1hZn/2 aZBDR2FYSD6D31rOogfag== |
| X-Ui-Out-Filterresults | notjunk:1;V01:K0:7rJ/3fxmFEI=:a/Y7RboEOFPnN3lb6lP8uO wrTkN97NMBnh25my8YeoHVZMz2/rcAKy1k8PdANxKUYipw0q3dKlxQXn9213QgAz9ZvSYLc0d ZjW/8YDpnCMYr6IMbtMq/20JuLnEobcq/axyPvR31xVPM7Lncc/EDhxvuLttovO0OY49i6qtf flcLLvG9JkNsIzlYMFy7BVmyMBKlMrUerN8EnJ6cETxWwhqiHRHEBLlff4bQy9MRdmEH15zyL mMky6xGoDL/vwiK1K2q1oJXQVl7JjvM9Vn6T4KGx2v7GXtJi3YzGPME8q6ew94jb1FzNl2hMZ +rUlEjX2YN2LzIihxkgfpIEITPZtKqT5vcGGqB+gZ1FGOjf60ydFXYsqNs2gtLTJ3PVlnG7+B 3C/LDUwDICB+7mtCFeudfZAreTRW0bDjvmiLMEMpfsj0joQxiSZsHeedOuBC3RruTUkcrdEq6 8ocVhrDm9r22Pc/fk1G+PZe0vadfy+nQSnJXhmcHwpE6yNfghjo1TOVJLCjruRN7QVDURXIfY QHq91fSr4RXIeqB+tMfftw8gZwjQZCO+NOdv/3cdGxbf+bP/0lz9ujN2CgyNJDV8U+4qykeG8 3SIeTmaSm+ESAfeiGUmy44vG1B2nvPM00qCIs+opB1oW5Y49nKkigU1xiXst5eLv3SDAaPGsg Ot2PLTfPBLen/JVawgohzsll2DBk/FKhsyNUo6ukXjAeeLqAzdzQ4F2vwfgI7po1F6m8= |
| Sender | robomod@news.nic.it |
| List-ID | <linux-kernel.vger.kernel.org> |
| X-Mailing-List | linux-kernel@vger.kernel.org |
| Approved | robomod@news.nic.it |
| Lines | 45 |
| Organization | linux.* mail to news gateway |
| X-Original-Cc | Arnd Bergmann <arnd@arndb.de>, Nicolas Ferre <nicolas.ferre@microchip.com>, Alexandre Belloni <alexandre.belloni@free-electrons.com>, linux-arm-kernel@lists.infradead.org, linux-usb@vger.kernel.org, linux-kernel@vger.kernel.org |
| X-Original-Date | Wed, 22 Feb 2017 11:33:27 +0100 |
| X-Original-Message-ID | <20170222103348.3947633-1-arnd@arndb.de> |
| X-Original-Sender | linux-kernel-owner@vger.kernel.org |
| Xref | csiph.com linux.kernel:1586052 |
Show key headers only | View raw
The debug output now contains the wrong variable, as seen from the compiler
warning:
drivers/usb/gadget/udc/atmel_usba_udc.c: In function 'usba_ep_enable':
drivers/usb/gadget/udc/atmel_usba_udc.c:632:550: error: 'ept_cfg' may be used uninitialized in this function [-Werror=maybe-uninitialized]
DBG(DBG_ERR, "%s: EPT_CFG = 0x%lx (maxpacket = %lu)\n",
This changes the debug output the same way as the other code.
Fixes: 741d2558bf0a ("usb: gadget: udc: atmel: Update endpoint allocation scheme")
Signed-off-by: Arnd Bergmann <arnd@arndb.de>
Acked-by: Alexandre Belloni <alexandre.belloni@free-electrons.com>
Acked-by: Nicolas Ferre <nicolas.ferre@microchip.com>
---
Originally sent on Feb 1, but this was never picked up. Resending it now,
as it is one of the few remaining build regressions in linux-next compared
to linux-4.10.
drivers/usb/gadget/udc/atmel_usba_udc.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/usb/gadget/udc/atmel_usba_udc.c b/drivers/usb/gadget/udc/atmel_usba_udc.c
index 11bbce28bc23..2035906b8ced 100644
--- a/drivers/usb/gadget/udc/atmel_usba_udc.c
+++ b/drivers/usb/gadget/udc/atmel_usba_udc.c
@@ -610,7 +610,7 @@ usba_ep_enable(struct usb_ep *_ep, const struct usb_endpoint_descriptor *desc)
{
struct usba_ep *ep = to_usba_ep(_ep);
struct usba_udc *udc = ep->udc;
- unsigned long flags, ept_cfg, maxpacket;
+ unsigned long flags, maxpacket;
unsigned int nr_trans;
DBG(DBG_GADGET, "%s: ep_enable: desc=%p\n", ep->ep.name, desc);
@@ -630,7 +630,7 @@ usba_ep_enable(struct usb_ep *_ep, const struct usb_endpoint_descriptor *desc)
ep->is_in = 0;
DBG(DBG_ERR, "%s: EPT_CFG = 0x%lx (maxpacket = %lu)\n",
- ep->ep.name, ept_cfg, maxpacket);
+ ep->ep.name, ep->ept_cfg, maxpacket);
if (usb_endpoint_dir_in(desc)) {
ep->is_in = 1;
--
2.9.0
Back to linux.kernel | Previous | Next | Find similar | Unroll thread
[PATCH, RESEND] usb: gadget: udc: atmel: fix debug output Arnd Bergmann <arnd@arndb.de> - 2017-02-22 11:40 +0100
csiph-web