Re: [next-20170217] WARN @/arch/powerpc/include/asm/xics.h:124 .icp_hv_eoi+0x40/0x140

From	Thomas Gleixner <tglx@linutronix.de>
Newsgroups	linux.kernel
Subject	Re: [next-20170217] WARN @/arch/powerpc/include/asm/xics.h:124 .icp_hv_eoi+0x40/0x140
Date	2017-02-20 23:10 +0100
Message-ID	<td4jD-1Zp-15@gated-at.bofh.it> (permalink)
References	<tcOoy-gL-19@gated-at.bofh.it> <tcOoy-gL-21@gated-at.bofh.it> <tcOoy-gL-17@gated-at.bofh.it> <tcTRf-3AN-13@gated-at.bofh.it> <td3dT-16y-5@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw

On Tue, 21 Feb 2017, Benjamin Herrenschmidt wrote:

> On Mon, 2017-02-20 at 21:55 +1100, Michael Ellerman wrote:
> > But when we're called for CONFIG_DEBUG_SHIRQ get_irq() is not called,
> > precisely because we're faking an interrupt.
> > 
> > I'm not sure if there's a good way to fix it :/
> 
> In the irq_replay path we have code to adjust the CPPR stack. We could
> do something similar.
> 
> HOWEVER. Looking at current upstream code I don't understand the error,
> the DEBUG_SHIRQ code is calling the driver's handler not the flow
> handler so it shouldn't be called handle_fasteoi_irq or am I missing
> something ?

I tried to invoke the normal handler path which also invokes the flow
handler, but that breaks on x86 as well for different reasons. I zapped
that commit and still need to find a way to do that debug thing proper. So
it's appearence in -next was only temporary.

Thanks,

	tglx

Thread

Re: [next-20170217] WARN @/arch/powerpc/include/asm/xics.h:124  .icp_hv_eoi+0x40/0x140 Sachin Sant <sachinp@linux.vnet.ibm.com> - 2017-02-20 06:10 +0100
  Re: [next-20170217] WARN @/arch/powerpc/include/asm/xics.h:124 .icp_hv_eoi+0x40/0x140 Michael Ellerman <mpe@ellerman.id.au> - 2017-02-20 12:00 +0100
    Re: [next-20170217] WARN @/arch/powerpc/include/asm/xics.h:124  .icp_hv_eoi+0x40/0x140 Benjamin Herrenschmidt <benh@au1.ibm.com> - 2017-02-20 22:00 +0100
      Re: [next-20170217] WARN @/arch/powerpc/include/asm/xics.h:124  .icp_hv_eoi+0x40/0x140 Thomas Gleixner <tglx@linutronix.de> - 2017-02-20 23:10 +0100
        Re: [next-20170217] WARN @/arch/powerpc/include/asm/xics.h:124  .icp_hv_eoi+0x40/0x140 Benjamin Herrenschmidt <benh@au1.ibm.com> - 2017-02-20 23:20 +0100

csiph-web