Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1584807

Re: [PATCH] Staging: board: Fix macro code style error

Show all headers | View raw

On Mon, Feb 20, 2017 at 05:44:50PM +0000, Valentin Huebner wrote:
> Fixes a 'macro with flow control statement' checkpatch code style
> error by removing the board_staging() macro and replacing its two
> calls

checkpatch is wrong here, you are now adding more lines than you remove:

> Signed-off-by: Valentin Hübner <valentin.huebner@gmail.com>
> ---
>  drivers/staging/board/armadillo800eva.c | 10 +++++++++-
>  drivers/staging/board/board.h           | 11 -----------
>  drivers/staging/board/kzm9d.c           | 10 +++++++++-
>  3 files changed, 18 insertions(+), 13 deletions(-)

See?

There's nothing wrong with the macro as-is, it's like many other macros
we have for module init sequences.  checkpatch is just a hint, you still
have to use your brain :)

sorry,

greg k-h

Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread

Thread

[PATCH] Staging: board: Fix macro code style error Valentin Huebner <valentin.huebner@gmail.com> - 2017-02-20 18:50 +0100
  Re: [PATCH] Staging: board: Fix macro code style error Greg Kroah-Hartman <gregkh@linuxfoundation.org> - 2017-02-20 19:10 +0100
    Re: [PATCH] Staging: board: Fix macro code style error Valentin Hübner <valentin.huebner@gmail.com> - 2017-02-21 16:30 +0100

csiph-web