Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1584796

Re: [RFC 1/5] iwlwifi: fix drv cleanup on opmode registration failure

Show all headers | View raw

On Sun, Feb 19, 2017 at 09:16:01AM +0000, Grumbach, Emmanuel wrote:
> > This should in theory fix a detangled drv from the drv list should either of the
> > opmode modules loaded and handled registration for the drv.
> > 
> > The path of having the opmode registration deal with the drv opmode start is
> > actually the more common path. The other path, from the async callback is
> > rathe rare (1/8 or so times for me) -- it happens when the the opmode
> > driver's init routine completed prior to the driver's async callback opmode
> > start call.
> 
> I'd claim it should never happen unless you have several devices on the system using the same
> opmode, or unless you do:
> modprobe iwlwifi  #which will load iwl{d,m}vm
> rmmod iwl{d,m}vm #and do _not_ remove iwlwifi
> modprobe iwlwifi

That is indeed one way one can easily reproduce this. There are however other
ways too. Try a loop of

modprobe -r iwlmvm (which removes iwlwifi) followed by modprobe iwlmvm;

while this check for which path is taken, or better yet check if the
list of drvs is empty on opmode registration. Every now and then I see
the list is empty.

I have a feeling this is then also a rare rarely observed by your QA team
as well, so this code then is also stitching together a set of sequence
calls for both paths.

> > Signed-off-by: Luis R. Rodriguez <mcgrof@kernel.org>
> > ---
> 
> Luca is OOO,  but this looks fine to me.

Reviewed-by ?

  Luis

Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread

Thread

[RFC 0/5] iwlwifi: enhance final opmode work "Luis R. Rodriguez" <mcgrof@kernel.org> - 2017-02-17 03:20 +0100
  [RFC 2/5] iwlwifi: fix request_module() use "Luis R. Rodriguez" <mcgrof@kernel.org> - 2017-02-17 03:20 +0100
    RE: [RFC 2/5] iwlwifi: fix request_module() use "Grumbach, Emmanuel" <emmanuel.grumbach@intel.com> - 2017-02-19 10:50 +0100
      Re: [RFC 2/5] iwlwifi: fix request_module() use "Luis R. Rodriguez" <mcgrof@kernel.org> - 2017-02-21 03:30 +0100
        RE: [RFC 2/5] iwlwifi: fix request_module() use "Grumbach, Emmanuel" <emmanuel.grumbach@intel.com> - 2017-02-21 08:20 +0100
          Re: [RFC 2/5] iwlwifi: fix request_module() use "Luis R. Rodriguez" <mcgrof@kernel.org> - 2017-02-21 19:20 +0100
            Re: [RFC 2/5] iwlwifi: fix request_module() use "Luis R. Rodriguez" <mcgrof@kernel.org> - 2017-02-21 21:20 +0100
              Re: [RFC 2/5] iwlwifi: fix request_module() use "Luis R. Rodriguez" <mcgrof@kernel.org> - 2017-02-22 01:20 +0100
                [PATCH v2 0/2] iwlwifi: share opmode start code "Luis R. Rodriguez" <mcgrof@kernel.org> - 2017-02-22 03:20 +0100
                [PATCH v2 2/2] iwlwifi: convert final opmode work into a workqueue "Luis R. Rodriguez" <mcgrof@kernel.org> - 2017-02-22 03:20 +0100
                [PATCH v2 1/2] iwlwifi: share opmode start work code "Luis R. Rodriguez" <mcgrof@kernel.org> - 2017-02-22 03:20 +0100
                [PATCH v2 1/2] iwlwifi: fix drv cleanup on opmode registration failure "Luis R. Rodriguez" <mcgrof@kernel.org> - 2017-02-22 03:20 +0100
                [PATCH v2 0/2] iwlwifi: corner case fix and request module changes "Luis R. Rodriguez" <mcgrof@kernel.org> - 2017-02-22 03:20 +0100
                [PATCH v2 2/2] iwlwifi: simplify requesting ops module "Luis R. Rodriguez" <mcgrof@kernel.org> - 2017-02-22 03:20 +0100
  [RFC 1/5] iwlwifi: fix drv cleanup on opmode registration failure "Luis R. Rodriguez" <mcgrof@kernel.org> - 2017-02-17 03:20 +0100
    RE: [RFC 1/5] iwlwifi: fix drv cleanup on opmode registration  failure "Grumbach, Emmanuel" <emmanuel.grumbach@intel.com> - 2017-02-19 10:20 +0100
      Re: [RFC 1/5] iwlwifi: fix drv cleanup on opmode registration failure "Luis R. Rodriguez" <mcgrof@kernel.org> - 2017-02-20 18:40 +0100
  [RFC 3/5] iwlwifi: share opmode start work code "Luis R. Rodriguez" <mcgrof@kernel.org> - 2017-02-17 03:20 +0100
  [RFC 5/5] iwlwifi: convert final opmode work into a workqueue "Luis R. Rodriguez" <mcgrof@kernel.org> - 2017-02-17 03:20 +0100

csiph-web