Re: [PATCH] ASLA: emu10k1: constify snd_emux_operators structure

From	Takashi Sakamoto <o-takashi@sakamocchi.jp>
Newsgroups	linux.kernel
Subject	Re: [PATCH] ASLA: emu10k1: constify snd_emux_operators structure
Date	2017-02-19 13:40 +0100
Message-ID	<tcyWt-7nn-5@gated-at.bofh.it> (permalink)
References	<tcwUG-6c7-3@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw

On Feb 19 2016 19:21, Bhumika Goyal wrote:
> Declare snd_emux_operators structure as const as it is only copied into
> another structure. So, snd_emux_operators structures having this property
> can be made const.
>
> Signed-off-by: Bhumika Goyal <bhumirks@gmail.com>

Reviewed-by: Takashi Sakamoto <o-takashi@sakamocchi.jp>

...The 'ASLA' reminds me of the god in Indian myth[0]. When Buddhism 
disseminated to Japan via China, the god changed its name and became the 
god in Japanese Buddhism, too.

...I'm just a kidding. The title should be fixed with 'ALSA' ;)

> ---
>  sound/pci/emu10k1/emu10k1_callback.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/sound/pci/emu10k1/emu10k1_callback.c b/sound/pci/emu10k1/emu10k1_callback.c
> index d2c7ea3..aa2cc27 100644
> --- a/sound/pci/emu10k1/emu10k1_callback.c
> +++ b/sound/pci/emu10k1/emu10k1_callback.c
> @@ -61,7 +61,7 @@ static struct snd_emux_voice *get_voice(struct snd_emux *emux,
>  /*
>   * set up operators
>   */
> -static struct snd_emux_operators emu10k1_ops = {
> +static const struct snd_emux_operators emu10k1_ops = {
>  	.owner =	THIS_MODULE,
>  	.get_voice =	get_voice,
>  	.prepare =	start_voice,

[0] https://en.wikipedia.org/wiki/Asura
[1] https://en.wikipedia.org/wiki/Asura_(Buddhism)


Regards

Takashi Sakamoto

Back to linux.kernel | Previous | Next — Previous in thread | Find similar | Unroll thread

Thread

[PATCH] ASLA: emu10k1: constify snd_emux_operators structure Bhumika Goyal <bhumirks@gmail.com> - 2017-02-19 11:30 +0100
  Re: [PATCH] ASLA: emu10k1: constify snd_emux_operators structure Takashi Iwai <tiwai@suse.de> - 2017-02-19 13:20 +0100
  Re: [PATCH] ASLA: emu10k1: constify snd_emux_operators structure Takashi Sakamoto <o-takashi@sakamocchi.jp> - 2017-02-19 13:40 +0100

csiph-web