Re: [Outreachy kernel] [PATCH] staging: xgifb: function definition argument should also have an identifier name'

From	Julia Lawall <julia.lawall@lip6.fr>
Newsgroups	linux.kernel
Subject	Re: [Outreachy kernel] [PATCH] staging: xgifb: function definition argument should also have an identifier name'
Date	2017-02-18 14:50 +0100
Message-ID	<tcdyF-2wI-3@gated-at.bofh.it> (permalink)
References	<tcdyF-2wI-1@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw


On Sat, 18 Feb 2017, Arushi Singhal wrote:

> function definition argument 'struct vb_device_info *' and 'unsigned
> long' should also have an identifier name.
>
> Signed-off-by: Arushi Singhal <arushisinghal19971997@gmail.com>

Acked-by: Julia Lawall <julia.lawall@lip6.fr>

> ---
>  drivers/staging/xgifb/vb_init.h | 3 +--
>  1 file changed, 1 insertion(+), 2 deletions(-)
>
> diff --git a/drivers/staging/xgifb/vb_init.h b/drivers/staging/xgifb/vb_init.h
> index 500cabe41a3c..e835054b87bf 100644
> --- a/drivers/staging/xgifb/vb_init.h
> +++ b/drivers/staging/xgifb/vb_init.h
> @@ -1,6 +1,5 @@
>  #ifndef _VBINIT_
>  #define _VBINIT_
>  unsigned char XGIInitNew(struct pci_dev *pdev);
> -void XGIRegInit(struct vb_device_info *, unsigned long);
> +void XGIRegInit(struct vb_device_info *XGI_Pr, unsigned long BaseAddr);
>  #endif
> -
> --
> 2.11.0
>
> --
> You received this message because you are subscribed to the Google Groups "outreachy-kernel" group.
> To unsubscribe from this group and stop receiving emails from it, send an email to outreachy-kernel+unsubscribe@googlegroups.com.
> To post to this group, send email to outreachy-kernel@googlegroups.com.
> To view this discussion on the web visit https://groups.google.com/d/msgid/outreachy-kernel/20170218134004.GA5075%40arushi-HP-Pavilion-Notebook.
> For more options, visit https://groups.google.com/d/optout.
>

Back to linux.kernel | Previous | Next | Find similar | Unroll thread

Thread

Re: [Outreachy kernel] [PATCH] staging: xgifb: function definition  argument should also have an identifier name' Julia Lawall <julia.lawall@lip6.fr> - 2017-02-18 14:50 +0100

csiph-web