Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1584738

[PATCH 0/3] Fix tsc2007 to report ABS_PRESSURE correctly

Show all headers | View raw

tsc2007 reports the touch resistance as ABS_PRESSURE, which jumps
to its maximum for light touch and goes down for increasing pressure.
This is not consistent with other touch drivers and not what one would
expect.

Additionally the name of the function tsc2007_calculate_pressure()
is misleading since the formula calculates an estimate for the touch
screen resistance. So it is renamed without changing the function.

While this patch changes the values reported to userspace,
ABS_PRESSURE is used rarely by userspace. Most software only
relies on BTN_TOUCH (boolean), which is not affected by this
patch. Some graphics software makes use of the interface and
does not work correctly with the currently used inverted
behaviour.

Note: this patch series assumes to be merged after

	"Input: tsc2007 - add iio interface to read external ADC input and temperature"

because that one renames tsc2007.c to tsc2007_core.c

H. Nikolaus Schaller (3):
  Input: tsc2007 - rename function tsc2007_calculate_pressure to
    tsc2007_calculate_resistance     because that is what it does
  Input: tsc2007 - correctly report pressure and not resistance to user
    space
  Input: tsc2007 - add a property "ti,report-resistance" to restore the
    old pressure reporting state     if needed.

 .../devicetree/bindings/input/touchscreen/tsc2007.txt      |  2 ++
 drivers/input/touchscreen/tsc2007.h                        |  1 +
 drivers/input/touchscreen/tsc2007_core.c                   | 14 ++++++++++----
 3 files changed, 13 insertions(+), 4 deletions(-)

-- 
2.7.3

Back to linux.kernel | Previous | Next — Next in thread | Find similar | Unroll thread

Thread

[PATCH 0/3] Fix tsc2007 to report ABS_PRESSURE correctly "H. Nikolaus Schaller" <hns@goldelico.com> - 2017-02-20 18:00 +0100
  [PATCH 3/3] Input: tsc2007 - add a property "ti,report-resistance" to restore the old pressure reporting state if needed. "H. Nikolaus Schaller" <hns@goldelico.com> - 2017-02-20 18:00 +0100
    Re: [PATCH 3/3] Input: tsc2007 - add a property  "ti,report-resistance" to restore the old pressure reporting state if  needed. Pavel Machek <pavel@ucw.cz> - 2017-02-21 12:10 +0100
      Re: [PATCH 3/3] Input: tsc2007 - add a property "ti,report-resistance" to restore the old pressure reporting state if needed. "H. Nikolaus Schaller" <hns@goldelico.com> - 2017-02-21 12:50 +0100
        Re: [PATCH 3/3] Input: tsc2007 - add a property  "ti,report-resistance" to restore the old pressure reporting state if  needed. Sebastian Reichel <sre@kernel.org> - 2017-02-21 18:30 +0100
  [PATCH 1/3] Input: tsc2007 - rename function tsc2007_calculate_pressure to tsc2007_calculate_resistance because that is what it does "H. Nikolaus Schaller" <hns@goldelico.com> - 2017-02-20 18:00 +0100
    Re: [PATCH 1/3] Input: tsc2007 - rename function  tsc2007_calculate_pressure to tsc2007_calculate_resistance because that is  what it does Dmitry Torokhov <dmitry.torokhov@gmail.com> - 2017-02-23 09:50 +0100

csiph-web