Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]


Groups > linux.kernel > #1584777

Re: [PATCH 2/4] perf: Keep AUX flags in the output handle

From Alexander Shishkin <alexander.shishkin@linux.intel.com>
Newsgroups linux.kernel
Subject Re: [PATCH 2/4] perf: Keep AUX flags in the output handle
Date 2017-02-20 18:20 +0100
Message-ID <tcZN0-7x5-29@gated-at.bofh.it> (permalink)
References <tcZDk-7to-17@gated-at.bofh.it>
Organization linux.* mail to news gateway

Show all headers | View raw


kbuild test robot <lkp@intel.com> writes:

> All errors (new ones prefixed by >>):
>
>    In file included from ./arch/arm64/include/generated/asm/local.h:1:0,
>                     from drivers/hwtracing/coresight/coresight-etb10.c:15:
>    drivers/hwtracing/coresight/coresight-etb10.c: In function 'etb_update_buffer':
>>> drivers/hwtracing/coresight/coresight-etb10.c:431:17: error: 'struct cs_buffers' has no member named 'lost'
>       local_inc(&buf->lost);
>                     ^
>    include/asm-generic/local.h:30:40: note: in definition of macro 'local_inc'

Ah shoot. Peter, can you fold this in:

From 8272adc208eb2ad874e3952766282624d035ea50 Mon Sep 17 00:00:00 2001
From: Alexander Shishkin <alexander.shishkin@linux.intel.com>
Date: Mon, 20 Feb 2017 19:15:27 +0200
Subject: [PATCH] fixup! perf: Keep AUX flags in the output handle

---
 drivers/hwtracing/coresight/coresight-etb10.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/hwtracing/coresight/coresight-etb10.c b/drivers/hwtracing/coresight/coresight-etb10.c
index 82c8ddcf09..979ea6ec79 100644
--- a/drivers/hwtracing/coresight/coresight-etb10.c
+++ b/drivers/hwtracing/coresight/coresight-etb10.c
@@ -428,7 +428,7 @@ static void etb_update_buffer(struct coresight_device *csdev,
 		if (read_ptr > (drvdata->buffer_depth - 1))
 			read_ptr -= drvdata->buffer_depth;
 		/* let the decoder know we've skipped ahead */
-		local_inc(&buf->lost);
+		perf_aux_output_flag(handle, PERF_AUX_FLAG_TRUNCATED);
 	}
 
 	/* finally tell HW where we want to start reading from */
-- 
2.11.0

Back to linux.kernel | Previous | Next | Find similar | Unroll thread


Thread

Re: [PATCH 2/4] perf: Keep AUX flags in the output handle Alexander Shishkin <alexander.shishkin@linux.intel.com> - 2017-02-20 18:20 +0100

csiph-web