Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]
Groups > linux.kernel > #1584704
| From | Andy Shevchenko <andriy.shevchenko@linux.intel.com> |
|---|---|
| Newsgroups | linux.kernel |
| Subject | [PATCH v1 2/4] gpio: of: Don't return 0 on dt_gpio_count() |
| Date | 2017-02-20 17:20 +0100 |
| Message-ID | <tcYQW-6Uz-15@gated-at.bofh.it> (permalink) |
| References | <tcYQW-6Uz-7@gated-at.bofh.it> |
| Organization | linux.* mail to news gateway |
It's unusual to have error checking like (ret <= 0) in cases when counting GPIO resources. In case when it's mandatory we propagate the error (-ENOENT), otherwise we don't use the result. This makes consistent behaviour across all possible variants called in gpiod_count(). Signed-off-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com> --- drivers/gpio/gpiolib.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/gpio/gpiolib.c b/drivers/gpio/gpiolib.c index 8b4d721d6d63..f8ee417de0b7 100644 --- a/drivers/gpio/gpiolib.c +++ b/drivers/gpio/gpiolib.c @@ -3122,10 +3122,10 @@ static int dt_gpio_count(struct device *dev, const char *con_id) gpio_suffixes[i]); ret = of_gpio_named_count(dev->of_node, propname); - if (ret >= 0) + if (ret > 0) break; } - return ret; + return ret ? ret : -ENOENT; } static int platform_gpio_count(struct device *dev, const char *con_id) -- 2.11.0
Back to linux.kernel | Previous | Next | Find similar | Unroll thread
[PATCH v1 2/4] gpio: of: Don't return 0 on dt_gpio_count() Andy Shevchenko <andriy.shevchenko@linux.intel.com> - 2017-02-20 17:20 +0100
csiph-web