RE: [PATCH 06/19] kernel: convert perf_event_context.refcount from atomic_t to refcount_t

From	"Reshetova, Elena" <elena.reshetova@intel.com>
Newsgroups	linux.kernel
Subject	RE: [PATCH 06/19] kernel: convert perf_event_context.refcount from atomic_t to refcount_t
Date	2017-02-20 13:20 +0100
Message-ID	<tcV6F-4y6-5@gated-at.bofh.it> (permalink)
References	<tcTod-3qg-9@gated-at.bofh.it> <tcTod-3qg-13@gated-at.bofh.it> <tcTxU-3tt-23@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw

> On Mon, Feb 20, 2017 at 12:18:55PM +0200, Elena Reshetova wrote:
> > +++ b/kernel/events/core.c
> > @@ -1108,7 +1108,7 @@ static void perf_event_ctx_deactivate(struct
> perf_event_context *ctx)
> >
> >  static void get_ctx(struct perf_event_context *ctx)
> >  {
> > -	WARN_ON(!atomic_inc_not_zero(&ctx->refcount));
> > +	WARN_ON(!refcount_inc_not_zero(&ctx->refcount));
> >  }
> 
> You can change that to refcount_inc(), as that has the exact same
> semantics.

True, will fix. Thanks!

Back to linux.kernel | Previous | Next — Previous in thread | Find similar | Unroll thread

Thread

[PATCH 06/19] kernel: convert perf_event_context.refcount from atomic_t to refcount_t Elena Reshetova <elena.reshetova@intel.com> - 2017-02-20 11:30 +0100
  Re: [PATCH 06/19] kernel: convert perf_event_context.refcount from  atomic_t to refcount_t Peter Zijlstra <peterz@infradead.org> - 2017-02-20 11:40 +0100
    RE: [PATCH 06/19] kernel: convert perf_event_context.refcount from  atomic_t to refcount_t "Reshetova, Elena" <elena.reshetova@intel.com> - 2017-02-20 13:20 +0100

csiph-web