Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1584548

Re: [PATCH] thermal: mt8173: minor mtk_thermal.c cleanups

Show key headers only | View raw

On 19/02/17 02:23, Eduardo Valentin wrote:
> On Mon, Feb 13, 2017 at 05:01:58PM +0800, Dawei Chien wrote:
>> Hi, Matthias,
>>
>> On Thu, 2017-02-09 at 22:25 +0100, Matthias Brugger wrote:
>>>
>>> On 02/08/2017 06:31 AM, Dawei Chien wrote:
>>>> Thermal driver should read TEMP_MSR3 if thermal bank with 4 sensors.
>>>> However, Currently thermal driver don't need read TEMP_MSR3 since
>>>> thermal controller only use 3 sensors for each thermal bank.
>>>>
>>>> Signed-off-by: Dawei Chien <dawei.chien@mediatek.com>
>>>> ---
>>>
>>> Actually the commit message should state:
>>> Fixes: b7cf0053738c ("thermal: Add Mediatek thermal driver for mt2701.")
>>>
>>> ...and get backported to v4.9 and v4.10.
>>>
>>> Reviewed-by: Matthias Brugger <matthias.bgg@gmail.com>
>>>
>>> Regards,
>>> Matthias
>>
>> Thank you for your review. I would add below commit message on next
>> version. However, currently 8173 thermal driver would not read TEMP_MSR3
>> since thermal driver only use 3 sensors on each bank, this patch would
>> not effect temperature.
>> Only if thermal driver use 4 sensors on any thermal bank, would read
>> third sensor two times, and lose fourth sensor of vale.
>> Fixes: b7cf0053738c ("thermal: Add Mediatek thermal driver for mt2701.")
>>
>
> Please send a new version with the tag in the commit message.
>

And don't forget to add stable@vger.kernel.org so that the fix ends up 
in the older kernels as well.

Regards,
Matthias

Back to linux.kernel | Previous | Next — Previous in thread | Find similar | Unroll thread

Thread

Re: [PATCH] thermal: mt8173: minor mtk_thermal.c cleanups Eduardo Valentin <edubezval@gmail.com> - 2017-02-19 02:30 +0100
  Re: [PATCH] thermal: mt8173: minor mtk_thermal.c cleanups Matthias Brugger <matthias.bgg@gmail.com> - 2017-02-20 12:40 +0100

csiph-web