Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1584408

Re: [PATCH] iio: adc: xilinx: Fix error handling

From Lars-Peter Clausen <lars@metafoo.de>
Newsgroups linux.kernel
Subject Re: [PATCH] iio: adc: xilinx: Fix error handling
Date 2017-02-20 09:40 +0100
Message-ID <tcRFM-2hh-17@gated-at.bofh.it> (permalink)
References <tcGr0-3xO-15@gated-at.bofh.it>
Organization linux.* mail to news gateway

Show all headers | View raw

On 02/19/2017 09:29 PM, Christophe JAILLET wrote:
> Reorder error handling labels in order to match the way resources have
> been allocated.
> 
> Signed-off-by: Christophe JAILLET <christophe.jaillet@wanadoo.fr>

Thanks, looks good.

Acked-by: Lars-Peter Clausen <lars@metafoo.de>

I think there is one more issue

    ret = xadc->ops->setup(pdev, indio_dev, irq);
    if (ret)
        goto err_free_samplerate_trigger;

should be

	goto err_clk_disable_unprepare;

Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread

Thread

[PATCH] iio: adc: xilinx: Fix error handling Christophe JAILLET <christophe.jaillet@wanadoo.fr> - 2017-02-19 21:40 +0100
  Re: [PATCH] iio: adc: xilinx: Fix error handling Lars-Peter Clausen <lars@metafoo.de> - 2017-02-20 09:40 +0100
  Re: [PATCH] iio: adc: xilinx: Fix error handling Christophe JAILLET <christophe.jaillet@wanadoo.fr> - 2017-02-20 21:30 +0100
    Re: [PATCH] iio: adc: xilinx: Fix error handling Lars-Peter Clausen <lars@metafoo.de> - 2017-02-20 22:10 +0100

csiph-web