Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1584405

[PATCH] Staging: comedi: drivers: comedi_test: Avoid multiple line dereference

Show all headers | View raw

Fix checkpatch warning "Avoid multiple line dereference"
using a local variable to avoid line wrap.

Signed-off-by: Cheah Kok Cheong <thrust73@gmail.com>
---
 drivers/staging/comedi/drivers/comedi_test.c | 6 ++----
 1 file changed, 2 insertions(+), 4 deletions(-)

diff --git a/drivers/staging/comedi/drivers/comedi_test.c b/drivers/staging/comedi/drivers/comedi_test.c
index 2a063f0..fde83e0 100644
--- a/drivers/staging/comedi/drivers/comedi_test.c
+++ b/drivers/staging/comedi/drivers/comedi_test.c
@@ -480,11 +480,9 @@ static void waveform_ao_timer(unsigned long arg)
 			/* output the last scan */
 			for (i = 0; i < cmd->scan_end_arg; i++) {
 				unsigned int chan = CR_CHAN(cmd->chanlist[i]);
+				unsigned short d = devpriv->ao_loopbacks[chan];
 
-				if (comedi_buf_read_samples(s,
-							    &devpriv->
-							     ao_loopbacks[chan],
-							    1) == 0) {
+				if (!comedi_buf_read_samples(s, &d, 1)) {
 					/* unexpected underrun! (cancelled?) */
 					async->events |= COMEDI_CB_OVERFLOW;
 					goto underrun;
-- 
2.7.4

Back to linux.kernel | Previous | Next — Next in thread | Find similar | Unroll thread

Thread

[PATCH] Staging: comedi: drivers: comedi_test: Avoid multiple line dereference Cheah Kok Cheong <thrust73@gmail.com> - 2017-02-20 09:40 +0100
  Re: [PATCH] Staging: comedi: drivers: comedi_test: Avoid multiple  line dereference Ian Abbott <abbotti@mev.co.uk> - 2017-02-20 11:10 +0100
    Re: [PATCH] Staging: comedi: drivers: comedi_test: Avoid multiple  line dereference Cheah Kok Cheong <thrust73@gmail.com> - 2017-02-20 17:10 +0100
      Re: [PATCH] Staging: comedi: drivers: comedi_test: Avoid multiple  line dereference Ian Abbott <abbotti@mev.co.uk> - 2017-02-20 18:40 +0100
        Re: [PATCH] Staging: comedi: drivers: comedi_test: Avoid multiple  line dereference Cheah Kok Cheong <thrust73@gmail.com> - 2017-02-21 10:40 +0100
          Re: [PATCH] Staging: comedi: drivers: comedi_test: Avoid multiple  line dereference Ian Abbott <abbotti@mev.co.uk> - 2017-02-21 11:20 +0100
            Re: [PATCH] Staging: comedi: drivers: comedi_test: Avoid multiple  line dereference Valentin Rothberg <valentinrothberg@gmail.com> - 2017-02-21 11:30 +0100
              Re: [PATCH] Staging: comedi: drivers: comedi_test: Avoid multiple  line dereference Cheah Kok Cheong <thrust73@gmail.com> - 2017-02-21 17:40 +0100
                Re: [PATCH] Staging: comedi: drivers: comedi_test: Avoid multiple  line dereference Joe Perches <joe@perches.com> - 2017-02-21 18:30 +0100
                Re: [PATCH] Staging: comedi: drivers: comedi_test: Avoid multiple  line dereference Valentin Rothberg <valentinrothberg@gmail.com> - 2017-02-22 09:40 +0100

csiph-web