Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]
Groups > linux.kernel > #1584330
| From | "Hillf Danton" <hillf.zj@alibaba-inc.com> |
|---|---|
| Newsgroups | linux.kernel |
| Subject | Re: [PATCH] mm/thp/autonuma: Use TNF flag instead of vm fault. |
| Date | 2017-02-20 04:40 +0100 |
| Message-ID | <tcMZr-7Ku-3@gated-at.bofh.it> (permalink) |
| References | <tcwBj-65E-15@gated-at.bofh.it> |
| Organization | linux.* mail to news gateway |
On February 19, 2017 6:00 PM Aneesh Kumar K.V wrote:
>
> We are using wrong flag value in task_numa_falt function. This can result in
> us doing wrong numa fault statistics update, because we update num_pages_migrate
> and numa_fault_locality etc based on the flag argument passed.
>
> Signed-off-by: Aneesh Kumar K.V <aneesh.kumar@linux.vnet.ibm.com>
Fix: bae473a423 ("mm: introduce fault_env")
Acked-by: Hillf Danton <hillf.zj@alibaba-inc.com>
> ---
> mm/huge_memory.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/mm/huge_memory.c b/mm/huge_memory.c
> index 5f3ad65c85de..8f1d93257fb9 100644
> --- a/mm/huge_memory.c
> +++ b/mm/huge_memory.c
> @@ -1333,7 +1333,7 @@ int do_huge_pmd_numa_page(struct vm_fault *vmf, pmd_t pmd)
>
> if (page_nid != -1)
> task_numa_fault(last_cpupid, page_nid, HPAGE_PMD_NR,
> - vmf->flags);
> + flags);
>
> return 0;
> }
> --
> 2.7.4
Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread
[PATCH] mm/thp/autonuma: Use TNF flag instead of vm fault. "Aneesh Kumar K.V" <aneesh.kumar@linux.vnet.ibm.com> - 2017-02-19 11:10 +0100 Re: [PATCH] mm/thp/autonuma: Use TNF flag instead of vm fault. "Hillf Danton" <hillf.zj@alibaba-inc.com> - 2017-02-20 04:40 +0100 Re: [PATCH] mm/thp/autonuma: Use TNF flag instead of vm fault. Rik van Riel <riel@surriel.com> - 2017-02-20 15:00 +0100 Re: [PATCH] mm/thp/autonuma: Use TNF flag instead of vm fault. "Kirill A. Shutemov" <kirill@shutemov.name> - 2017-02-23 10:50 +0100
csiph-web