Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1584220

Re: [PATCH 1/2] staging: ks7010: Unnecessary parentheses are removed.

From Joe Perches <joe@perches.com>
Newsgroups linux.kernel
Subject Re: [PATCH 1/2] staging: ks7010: Unnecessary parentheses are removed.
Date 2017-02-19 19:40 +0100
Message-ID <tcEyR-2lV-5@gated-at.bofh.it> (permalink)
References <tcEpb-2iE-1@gated-at.bofh.it>
Organization linux.* mail to news gateway

Show all headers | View raw

On Sun, 2017-02-19 at 23:56 +0530, Arushi Singhal wrote:
> Unnecessary parentheses should be avoided as reported by checkpatch.pl.
> Remove unnecessary parentheses, as reported by checkpatch as are nicer
> to read.For example:-
> It's often nicer to read if &(foo[0]) is converted to foo like:
>      memcpy(&(ap->bssid[0]), &(ap_info->bssid[0]), ETH_ALEN);
>      memcpy(ap->bssid, ap_info->bssid, ETH_ALEN);
[]
> diff --git a/drivers/staging/ks7010/ks_hostif.c b/drivers/staging/ks7010/ks_hostif.c
[]
> @@ -212,7 +212,7 @@ int get_ap_information(struct ks_wlan_private *priv, struct ap_info_t *ap_info,
>  	memset(ap, 0, sizeof(struct local_ap_t));
>  
>  	/* bssid */
> -	memcpy(&(ap->bssid[0]), &(ap_info->bssid[0]), ETH_ALEN);
> +	memcpy(&ap->bssid[0], &ap_info->bssid[0], ETH_ALEN);

This code doesn't match the suggested style of
your commit message.

Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread

Thread

[PATCH 1/2] staging: ks7010: Unnecessary parentheses are removed. Arushi Singhal <arushisinghal19971997@gmail.com> - 2017-02-19 19:30 +0100
  Re: [PATCH 1/2] staging: ks7010: Unnecessary parentheses are  removed. Joe Perches <joe@perches.com> - 2017-02-19 19:40 +0100
    Re: [Outreachy kernel] Re: [PATCH 1/2] staging: ks7010: Unnecessary  parentheses are removed. Julia Lawall <julia.lawall@lip6.fr> - 2017-02-19 20:00 +0100
      Re: [Outreachy kernel] Re: [PATCH 1/2] staging: ks7010: Unnecessary  parentheses are removed. Joe Perches <joe@perches.com> - 2017-02-19 20:20 +0100
        Re: [Outreachy kernel] Re: [PATCH 1/2] staging: ks7010: Unnecessary  parentheses are removed. Julia Lawall <julia.lawall@lip6.fr> - 2017-02-19 20:30 +0100
  Re: [Outreachy kernel] [PATCH 1/2] staging: ks7010: Unnecessary  parentheses are removed. Julia Lawall <julia.lawall@lip6.fr> - 2017-02-19 20:00 +0100

csiph-web