Re: [PATCH] [RFC] drm: Nerf DRM_CONTROL nodes

From	Thomas Hellstrom <thomas@shipmail.org>
Newsgroups	linux.kernel
Subject	Re: [PATCH] [RFC] drm: Nerf DRM_CONTROL nodes
Date	2017-02-19 16:40 +0100
Message-ID	<tcBKG-Dv-19@gated-at.bofh.it> (permalink)
References	<tcBKG-Dv-21@gated-at.bofh.it> <tcBKG-Dv-23@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw

So I think we need a quick revert of this commit or a quick stable
follow-up to unbreak things on our side.

/Thomas


On 02/19/2017 03:54 PM, Thomas Hellstrom wrote:
> Hi!
>
> This patch breaks the vmwgfx resolutionKMS daemon which opens a control
> node to tell DRM about the monitor layout...
>
> /Thomas
>
>
> On 10/28/2016 10:10 AM, Daniel Vetter wrote:
>> Looking at the ioctl permission checks I noticed that it's impossible
>> to import gem buffers into a control nodes, and fd2handle/handle2fd
>> also don't work, so no joy with dma-bufs.
>>
>> The only way to do anything with a control node is by drawing stuff
>> into a dumb buffer and displaying that. I suspect control nodes are an
>> entirely unused thing, and a cursory check shows that there does not
>> seem to be any callers of drmOpenControl nor of the other drmOpen
>> functions using DRM_MODE_CONTROL.
>>
>> Since I don't like dead uabi, let's remove it. But since this would be
>> a really big change I think it's better to start out small by simply
>> not registering anything. We can garbage-collect the dead code later
>> on, once we're sure it's really not used anywhere.
>>
>> Signed-off-by: Daniel Vetter <daniel.vetter@intel.com>
>> ---
>>  drivers/gpu/drm/drm_drv.c | 6 ------
>>  1 file changed, 6 deletions(-)
>>
>> diff --git a/drivers/gpu/drm/drm_drv.c b/drivers/gpu/drm/drm_drv.c
>> index 6efdba4993fc..f085e28ffc6f 100644
>> --- a/drivers/gpu/drm/drm_drv.c
>> +++ b/drivers/gpu/drm/drm_drv.c
>> @@ -517,12 +517,6 @@ int drm_dev_init(struct drm_device *dev,
>>  		goto err_free;
>>  	}
>>  
>> -	if (drm_core_check_feature(dev, DRIVER_MODESET)) {
>> -		ret = drm_minor_alloc(dev, DRM_MINOR_CONTROL);
>> -		if (ret)
>> -			goto err_minors;
>> -	}
>> -
>>  	if (drm_core_check_feature(dev, DRIVER_RENDER)) {
>>  		ret = drm_minor_alloc(dev, DRM_MINOR_RENDER);
>>  		if (ret)
>
> _______________________________________________
> dri-devel mailing list
> dri-devel@lists.freedesktop.org
> https://lists.freedesktop.org/mailman/listinfo/dri-devel

Back to linux.kernel | Previous | Next — Next in thread | Find similar | Unroll thread

Thread

Re: [PATCH] [RFC] drm: Nerf DRM_CONTROL nodes Thomas Hellstrom <thomas@shipmail.org> - 2017-02-19 16:40 +0100
  Re: [PATCH] [RFC] drm: Nerf DRM_CONTROL nodes Daniel Vetter <daniel.vetter@ffwll.ch> - 2017-02-20 23:30 +0100
    Re: DRM_CONTROL node breakage (Re: [PATCH] [RFC] drm: Nerf  DRM_CONTROL nodes) David Airlie <airlied@redhat.com> - 2017-02-21 06:40 +0100
      Re: DRM_CONTROL node breakage (Re: [PATCH] [RFC] drm: Nerf  DRM_CONTROL nodes) Thomas Hellstrom <thomas@shipmail.org> - 2017-02-21 12:00 +0100
    DRM_CONTROL node breakage (Re: [PATCH] [RFC] drm: Nerf DRM_CONTROL  nodes) Thomas Hellstrom <thomas@shipmail.org> - 2017-02-21 06:40 +0100
    Re: [PATCH] [RFC] drm: Nerf DRM_CONTROL nodes Thomas Hellstrom <thomas@shipmail.org> - 2017-02-21 12:20 +0100

csiph-web