Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1584143

Re: [PATCH -v1.1] x86: Optimize clear_page()

Show all headers | View raw

On Wed, Feb 15, 2017 at 12:19:27PM +0100, Borislav Petkov wrote:
> Here's a fixed version of the breakage the 0day bot reported:
> 
> ---
> From: Borislav Petkov <bp@suse.de>
> Date: Thu, 9 Feb 2017 01:34:49 +0100
> Subject: [PATCH -v1.1] x86: Optimize clear_page()
> 
> Currently, we CALL clear_page() which then JMPs to the proper function
> chosen by the alternatives.
> 
> What we should do instead is CALL the proper function directly. (This
> was something Ingo suggested a while ago). So let's do that.
> 
> Measuring our favourite kernel build workload shows that there are no
> significant changes in performance.

...

> Signed-off-by: Borislav Petkov <bp@suse.de>
> [ Forgot to add clobbers. ]
> Reported-by: kernel test robot <fengguang.wu@intel.com>

Fengguang just confirmed too:

"Yes it works fine for 300 boots.

Tested-by: Fengguang Wu <fengguang.wu@intel.com>"

-- 
Regards/Gruss,
    Boris.

Good mailing practices for 400: avoid top-posting and trim the reply.

Back to linux.kernel | Previous | Next — Previous in thread | Find similar | Unroll thread

Thread

[PATCH -v1.1] x86: Optimize clear_page() Borislav Petkov <bp@alien8.de> - 2017-02-15 12:20 +0100
  Re: [PATCH -v1.1] x86: Optimize clear_page() Borislav Petkov <bp@alien8.de> - 2017-02-19 14:50 +0100

csiph-web