[PATCH v2 3/3] Make vmbus register arguments read-only

From	Eddie Kovsky <ewk@edkovsky.org>
Newsgroups	linux.kernel
Subject	[PATCH v2 3/3] Make vmbus register arguments read-only
Date	2017-02-18 07:10 +0100
Message-ID	<tc6nv-6t9-1@gated-at.bofh.it> (permalink)
References	<tc6nv-6t9-3@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw

Use the new RO check functions introduced in this series to make the
vmbus register functions verify that the address of their arguments are
read-only. Addresses that fail the verification are rejected.

Signed-off-by: Eddie Kovsky <ewk@edkovsky.org>
---
 drivers/hv/vmbus_drv.c | 10 ++++++++++
 1 file changed, 10 insertions(+)

diff --git a/drivers/hv/vmbus_drv.c b/drivers/hv/vmbus_drv.c
index c1b27026f744..e527454ffa59 100644
--- a/drivers/hv/vmbus_drv.c
+++ b/drivers/hv/vmbus_drv.c
@@ -1026,6 +1026,11 @@ int __vmbus_driver_register(struct hv_driver *hv_driver, struct module *owner, c
 	if (ret < 0)
 		return ret;

+	ret = kernel_ro_address(&hv_driver);
+	if (ret < 1)
+		pr_err("Module address is not read-only.");
+		return ret;
+
 	hv_driver->driver.name = hv_driver->name;
 	hv_driver->driver.owner = owner;
 	hv_driver->driver.mod_name = mod_name;
@@ -1092,6 +1097,11 @@ int vmbus_device_register(struct hv_device *child_device_obj)
 {
 	int ret = 0;

+	ret = kernel_ro_address(&child_device_obj);
+	if (ret < 1)
+		pr_err("Device address is not read-only.");
+		return ret;
+
 	dev_set_name(&child_device_obj->device, "%pUl",
 		     child_device_obj->channel->offermsg.offer.if_instance.b);

--
2.11.1

Back to linux.kernel | Previous | Next — Next in thread | Find similar | Unroll thread

Thread

[PATCH v2 3/3] Make vmbus register arguments read-only Eddie Kovsky <ewk@edkovsky.org> - 2017-02-18 07:10 +0100
  Re: [PATCH v2 3/3] Make vmbus register arguments read-only kbuild test robot <lkp@intel.com> - 2017-02-18 07:40 +0100

csiph-web