Re: [PATCH v4 20/36] media: imx: Add CSI subdev driver

From	Russell King - ARM Linux <linux@armlinux.org.uk>
Newsgroups	linux.kernel
Subject	Re: [PATCH v4 20/36] media: imx: Add CSI subdev driver
Date	2017-02-16 20:20 +0100
Message-ID	<tbzKV-2kI-1@gated-at.bofh.it> (permalink)
References	<tbjZv-8cO-3@gated-at.bofh.it> <tbjZv-8cO-5@gated-at.bofh.it> <tbsT8-5Hw-7@gated-at.bofh.it> <tbtFw-6dt-17@gated-at.bofh.it> <tbzhV-1Tc-25@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw

On Thu, Feb 16, 2017 at 10:44:16AM -0800, Steve Longerbeam wrote:
> On 02/16/2017 04:40 AM, Russell King - ARM Linux wrote:
> >[    8.012191] imx_media_common: module is from the staging directory, the quality is unknown, you have been warned.
> >[    8.018175] imx_media: module is from the staging directory, the quality is unknown, you have been warned.
> >[    8.748345] imx-media: Registered subdev ipu1_csi0_mux
> >[    8.753451] imx-media: Registered subdev ipu2_csi1_mux
> >[    9.055196] imx219 0-0010: detected IMX219 sensor
> >[    9.090733] imx6_mipi_csi2: module is from the staging directory, the quality is unknown, you have been warned.
> >[    9.092247] imx-media: Registered subdev imx219 0-0010
> >[    9.334338] imx-media: Registered subdev imx6-mipi-csi2
> >[    9.372452] imx_media_capture: module is from the staging directory, the quality is unknown, you have been warned.
> >[    9.378163] imx_media_capture: module is from the staging directory, the quality is unknown, you have been warned.
> >[    9.390033] imx_media_csi: module is from the staging directory, the quality is unknown, you have been warned.
> >[    9.394362] imx-media: Received unknown subdev ipu1_csi0
> 
> The root problem is here. I don't know why the CSI entities are not
> being recognized. Can you share the changes you made?

No, it's not the root problem that's causing the BUG/etc, but it is
_a_ problem.  Nevertheless, it's something I fixed - disconnecting
the of_node from the struct device needed one other change in the
imx-media code that was missing at this time.

However, that's no excuse what so ever for the BUG_ON() and lack of
error cleanup (causing use-after-free, which is just another way of
saying "data corruption waiting to happen") that I identified.

-- 
RMK's Patch system: http://www.armlinux.org.uk/developer/patches/
FTTC broadband for 0.8mile line: currently at 9.6Mbps down 400kbps up
according to speedtest.net.

Back to linux.kernel | Previous | Next — Previous in thread | Find similar | Unroll thread

Thread

[PATCH v4 20/36] media: imx: Add CSI subdev driver Steve Longerbeam <slongerbeam@gmail.com> - 2017-02-16 03:30 +0100
  Re: [PATCH v4 20/36] media: imx: Add CSI subdev driver Russell King - ARM Linux <linux@armlinux.org.uk> - 2017-02-16 13:00 +0100
    Re: [PATCH v4 20/36] media: imx: Add CSI subdev driver Russell King - ARM Linux <linux@armlinux.org.uk> - 2017-02-16 13:50 +0100
      Re: [PATCH v4 20/36] media: imx: Add CSI subdev driver Russell King - ARM Linux <linux@armlinux.org.uk> - 2017-02-16 14:20 +0100
        Re: [PATCH v4 20/36] media: imx: Add CSI subdev driver Russell King - ARM Linux <linux@armlinux.org.uk> - 2017-02-16 15:30 +0100
          Re: [PATCH v4 20/36] media: imx: Add CSI subdev driver Steve Longerbeam <slongerbeam@gmail.com> - 2017-02-16 20:10 +0100
      Re: [PATCH v4 20/36] media: imx: Add CSI subdev driver Steve Longerbeam <slongerbeam@gmail.com> - 2017-02-16 19:50 +0100
        Re: [PATCH v4 20/36] media: imx: Add CSI subdev driver Russell King - ARM Linux <linux@armlinux.org.uk> - 2017-02-16 20:20 +0100

csiph-web