Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1582584

Re: [PATCH 4/5] sprd_serial: switch comptible string to sc-uart

Show all headers | View raw

On Tuesday, February 14, 2017 5:19:11 PM CET Chunyan Zhang wrote:
>  static const struct of_device_id serial_ids[] = {
> -       {.compatible = "sprd,sc9836-uart",},
> +       {.compatible = "sprd,sc-uart",},
>         {}

We really need this to be specific, in case Spreadtrum ever
makes a slightly different UART that is not 100% compatible
with this one. Also, you can't remove the string you already have,
only add to it.

Normally when you have a new chip that is compatible with one
we already have a driver for, we mark the device as compatible
with the old one and avoid having to change the driver, e.g.

	compatible = "sprd,sc9995-uart", "sprd,sc9836-uart";

This way, the driver could later be changed to handle anything
that is compatible with sc9995 differently from sc9836, but
by default it would match the original string.

	Arnd

Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread

Thread

[PATCH 0/5] Add Spreadtrum SP9860G support Chunyan Zhang <chunyan.zhang@spreadtrum.com> - 2017-02-14 10:50 +0100
  [PATCH 5/5] serial: sprd: adjust TIMEOUT to a big value Chunyan Zhang <chunyan.zhang@spreadtrum.com> - 2017-02-14 10:50 +0100
  [PATCH 1/5] arm64: dts: Add basic DT to support Spreadtrum's SP9860G Chunyan Zhang <chunyan.zhang@spreadtrum.com> - 2017-02-14 10:50 +0100
    Re: [PATCH 1/5] arm64: dts: Add basic DT to support Spreadtrum's SP9860G Sudeep Holla <sudeep.holla@arm.com> - 2017-02-14 17:50 +0100
      Re: [PATCH 1/5] arm64: dts: Add basic DT to support Spreadtrum's  SP9860G Chunyan Zhang <chunyan.zhang@spreadtrum.com> - 2017-02-17 08:40 +0100
        Re: [PATCH 1/5] arm64: dts: Add basic DT to support Spreadtrum's  SP9860G Sudeep Holla <sudeep.holla@arm.com> - 2017-02-17 11:30 +0100
          Re: [PATCH 1/5] arm64: dts: Add basic DT to support Spreadtrum's  SP9860G Chunyan Zhang <chunyan.zhang@spreadtrum.com> - 2017-02-20 10:50 +0100
            Re: [PATCH 1/5] arm64: dts: Add basic DT to support Spreadtrum's  SP9860G Sudeep Holla <sudeep.holla@arm.com> - 2017-02-20 11:50 +0100
              Re: [PATCH 1/5] arm64: dts: Add basic DT to support Spreadtrum's  SP9860G Chunyan Zhang <chunyan.zhang@spreadtrum.com> - 2017-02-20 14:00 +0100
    Re: [PATCH 1/5] arm64: dts: Add basic DT to support Spreadtrum's  SP9860G Chunyan Zhang <chunyan.zhang@spreadtrum.com> - 2017-02-16 09:10 +0100
  [PATCH 4/5] sprd_serial: switch comptible string to sc-uart Chunyan Zhang <chunyan.zhang@spreadtrum.com> - 2017-02-14 10:50 +0100
    Re: [PATCH 4/5] sprd_serial: switch comptible string to sc-uart Arnd Bergmann <arnd@arndb.de> - 2017-02-16 14:40 +0100
      Re: [PATCH 4/5] sprd_serial: switch comptible string to sc-uart Chunyan Zhang <chunyan.zhang@spreadtrum.com> - 2017-02-17 08:40 +0100
  [PATCH 2/5] Documentation: sprd: Add bindings for SP9860G Chunyan Zhang <chunyan.zhang@spreadtrum.com> - 2017-02-14 10:50 +0100

csiph-web