Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]
Groups > linux.kernel > #1581714
| From | Andrew Lunn <andrew@lunn.ch> |
|---|---|
| Newsgroups | linux.kernel |
| Subject | Re: [PATCH] net: ethernet: cadence: Add fixed-link functionality |
| Date | 2017-02-15 23:20 +0100 |
| Message-ID | <tbg5z-5Kb-3@gated-at.bofh.it> (permalink) |
| References | <tbeGt-4Jp-9@gated-at.bofh.it> |
| Organization | linux.* mail to news gateway |
> @@ -3342,8 +3371,18 @@ static int macb_probe(struct platform_device *pdev)
> macb_get_hwaddr(bp);
>
> /* Power up the PHY if there is a GPIO reset */
> - phy_node = of_get_next_available_child(np, NULL);
> - if (phy_node) {
> + phy_node = of_parse_phandle(np, "phy-handle", 0);
> + if (!phy_node && of_phy_is_fixed_link(np)) {
> + err = of_phy_register_fixed_link(np);
Hi Moritz
I don't see any calls to of_phy_deregister_fixed_link(), either in the
error path, or the remove code.
Andrew
Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread
[PATCH] net: ethernet: cadence: Add fixed-link functionality mdf@kernel.org - 2017-02-15 21:50 +0100
Re: [PATCH] net: ethernet: cadence: Add fixed-link functionality Florian Fainelli <f.fainelli@gmail.com> - 2017-02-15 22:00 +0100
Re: [PATCH] net: ethernet: cadence: Add fixed-link functionality Moritz Fischer <mdf@kernel.org> - 2017-02-15 22:10 +0100
Re: [PATCH] net: ethernet: cadence: Add fixed-link functionality Andrew Lunn <andrew@lunn.ch> - 2017-02-15 23:20 +0100
Re: [PATCH] net: ethernet: cadence: Add fixed-link functionality Moritz Fischer <mdf@kernel.org> - 2017-02-15 23:40 +0100
csiph-web