Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]
Groups > linux.kernel > #1581639
| From | Dan Carpenter <dan.carpenter@oracle.com> |
|---|---|
| Newsgroups | linux.kernel |
| Subject | Re: [PATCH] staging: rtl8192u: Fix warnings about endianness |
| Date | 2017-02-15 21:40 +0100 |
| Message-ID | <tbewO-4G5-5@gated-at.bofh.it> (permalink) |
| References | <tb2Fk-5kr-1@gated-at.bofh.it> <tb3i2-5YV-7@gated-at.bofh.it> |
| Organization | linux.* mail to news gateway |
On Wed, Feb 15, 2017 at 09:33:15AM +0100, Arnd Bergmann wrote:
> I see the same warning was addressed very differently in 99277c1f9962
> ("Staging: rtl8192e: Fix Sparse warning of cast to restricted __le16 in
> rtllib_crypt_tkip.c"), which was for a close relative of that driver.
>
> Only one of the two approaches (at most) can be correct, so we
> regardless of your patch either rtl8192e or rtl8192u is broken on
> big-endian machines.
99277c1f9962 ("Staging: rtl8192e: Fix Sparse warning of cast to restricted __le16 in
rtllib_crypt_tkip.c") is obviously broken. Can you send a patch to
change it back?
regards,
dan carpenter
Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread
[PATCH] staging: rtl8192u: Fix warnings about endianness maomao xu <albert008.xu@gmail.com> - 2017-02-15 09:00 +0100
Re: [PATCH] staging: rtl8192u: Fix warnings about endianness Arnd Bergmann <arnd@arndb.de> - 2017-02-15 09:40 +0100
Re: [PATCH] staging: rtl8192u: Fix warnings about endianness Dan Carpenter <dan.carpenter@oracle.com> - 2017-02-15 21:40 +0100
Re: [PATCH] staging: rtl8192u: Fix warnings about endianness maomao <albert008.xu@gmail.com> - 2017-02-18 05:10 +0100
csiph-web