Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1581651

Re: [PATCH] drm/vc4: Drop debug print at boot with DPI enabled.

Show all headers | View raw

[Multipart message — attachments visible in raw view] - view raw

Daniel Vetter <daniel@ffwll.ch> writes:

> On Wed, Feb 08, 2017 at 12:47:01PM -0800, Eric Anholt wrote:
>> Unlike the other encoders in the driver, I've also dropped the debug
>> dump function.  There's only really one register to this device, and
>> we have the debugfs reg entry still.
>> 
>> Signed-off-by: Eric Anholt <eric@anholt.net>
>
> Yeah, dmesg spew by default isn't cool. Btw if you ever want to have fancy
> debug printers, there's drm_printer, which allows you to spam both dmesg
> and debugfs with the same code. Rob did that, I recently converted drm_mm,
> it's pretty cool.
>
> Acked-by: Daniel Vetter <daniel.vetter@ffwll.ch>

Merged to -next, thanks.

The drm printer stuff looks really promising!  I'm also interested,
though, in the debugfs_regset32 stuff that lets you just name your regs
in a struct and pass it and your regs base address to the helper for
creating the debugfs entry.  I bet we can mash those two ideas together
into something really nice.

Back to linux.kernel | Previous | Next | Find similar | Unroll thread

Thread

Re: [PATCH] drm/vc4: Drop debug print at boot with DPI enabled. Eric Anholt <eric@anholt.net> - 2017-02-15 22:00 +0100

csiph-web