Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]


Groups > linux.kernel > #1581570

Re: [PATCH] tpm: declare tpm2_get_pcr_allocation() as static

From Jason Gunthorpe <jgunthorpe@obsidianresearch.com>
Newsgroups linux.kernel
Subject Re: [PATCH] tpm: declare tpm2_get_pcr_allocation() as static
Date 2017-02-15 20:00 +0100
Message-ID <tbcY2-3Ds-17@gated-at.bofh.it> (permalink)
References <tbcbE-3la-23@gated-at.bofh.it>
Organization linux.* mail to news gateway

Show all headers | View raw


On Wed, Feb 15, 2017 at 08:02:28PM +0200, Jarkko Sakkinen wrote:
> There's no need to export tpm2_get_pcr_alloation() because it is only
> a helper function for tpm2_auto_startup(). For the same reason it does
> not make much sense to maintain documentation for it.

Please stop moving these functions around, you are just breaking the
git history and git blame - there cosmetic reason of having a certain
order is not worth this damage.

Jason

Back to linux.kernel | Previous | NextPrevious in thread | Next in thread | Find similar | Unroll thread


Thread

[PATCH] tpm: declare tpm2_get_pcr_allocation() as static Jarkko Sakkinen <jarkko.sakkinen@linux.intel.com> - 2017-02-15 19:10 +0100
  Re: [PATCH] tpm: declare tpm2_get_pcr_allocation() as static Jason Gunthorpe <jgunthorpe@obsidianresearch.com> - 2017-02-15 20:00 +0100
    Re: [PATCH] tpm: declare tpm2_get_pcr_allocation() as static Jarkko Sakkinen <jarkko.sakkinen@linux.intel.com> - 2017-02-15 20:10 +0100
  Re: [PATCH] tpm: declare tpm2_get_pcr_allocation() as static Jarkko Sakkinen <jarkko.sakkinen@linux.intel.com> - 2017-02-17 11:30 +0100
    Re: [tpmdd-devel] [PATCH] tpm: declare tpm2_get_pcr_allocation() as  static Jarkko Sakkinen <jarkko.sakkinen@linux.intel.com> - 2017-02-20 12:30 +0100
    Re: [PATCH] tpm: declare tpm2_get_pcr_allocation() as static Nayna <nayna@linux.vnet.ibm.com> - 2017-02-21 07:00 +0100
      Re: [PATCH] tpm: declare tpm2_get_pcr_allocation() as static Jarkko Sakkinen <jarkko.sakkinen@linux.intel.com> - 2017-02-21 07:20 +0100

csiph-web