Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]
Groups > linux.kernel > #1581423
| From | Vlastimil Babka <vbabka@suse.cz> |
|---|---|
| Newsgroups | linux.kernel |
| Subject | Re: [PATCH v2 00/10] try to reduce fragmenting fallbacks |
| Date | 2017-02-15 17:20 +0100 |
| Message-ID | <tbatc-2fc-35@gated-at.bofh.it> (permalink) |
| References | <t9nXA-6ZO-5@gated-at.bofh.it> <tamG6-2UT-33@gated-at.bofh.it> <tb8Ur-1ae-35@gated-at.bofh.it> |
| Organization | linux.* mail to news gateway |
On 02/15/2017 03:29 PM, Vlastimil Babka wrote:
> Results for patch 4 ("count movable pages when stealing from pageblock")
> are really puzzling me, as it increases the number of fragmenting events
> for reclaimable allocations, implicating "reclaimable placed with (i.e.
> falling back to) unmovable" (which is not listed separately above, but
> follows logically from "reclaimable placed with movable" not changing
> that much). I really wonder why is that. The patch effectively only
> changes the decision to change migratetype of a pageblock, it doesn't
> affect the actual stealing decision (which is always true for
> RECLAIMABLE anyway, see can_steal_fallback()). Moreover, since we can't
> distinguish UNMOVABLE from RECLAIMABLE when counting, good_pages is 0
> and thus even the decision to change pageblock migratetype shouldn't be
> changed by the patch for this case. I must recheck the implementation...
Ah, there it is... not enough LISP
- if (pages >= (1 << (pageblock_order-1)) ||
+ /* Claim the whole block if over half of it is free or good type */
+ if (free_pages + good_pages >= (1 << (pageblock_order-1)) ||
Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread
Re: [PATCH v2 00/10] try to reduce fragmenting fallbacks Vlastimil Babka <vbabka@suse.cz> - 2017-02-15 15:40 +0100
Re: [PATCH v2 00/10] try to reduce fragmenting fallbacks Vlastimil Babka <vbabka@suse.cz> - 2017-02-15 17:20 +0100
Re: [PATCH v2 00/10] try to reduce fragmenting fallbacks Vlastimil Babka <vbabka@suse.cz> - 2017-02-15 21:20 +0100
Re: [PATCH v2 00/10] try to reduce fragmenting fallbacks Vlastimil Babka <vbabka@suse.cz> - 2017-02-16 16:20 +0100
Re: [PATCH v2 00/10] try to reduce fragmenting fallbacks Vlastimil Babka <vbabka@suse.cz> - 2017-02-17 16:30 +0100
csiph-web