Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]


Groups > linux.kernel > #1581410

[PATCH v2] Power: supply: sbs-charger: simplified bool function

Path csiph.com!1.us.feeder.erje.net!2.us.feeder.erje.net!feeder.erje.net!2.eu.feeder.erje.net!news2.arglkargh.de!news.mixmin.net!aioe.org!bofh.it!news.nic.it!robomod
From Daniel Perez <danielperezdeandres@gmail.com>
Newsgroups linux.kernel
Subject [PATCH v2] Power: supply: sbs-charger: simplified bool function
Date Wed, 15 Feb 2017 16:50:02 +0100
Message-ID <tba09-1Py-9@gated-at.bofh.it> (permalink)
X-Original-To sre@kernel.org
Dkim-Signature v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:date:message-id; bh=vLi9K2thY2FMA0yC6zhhANB4Nf6FbsliWulsDYYMN7g=; b=qfoe91ZI9fnAxS37rS4P59pUuMCMSjIYtRlg0VnHLvK1VuGCO7gZCgM8I0tt4w9kSl hE0Qb+xyCedbtZvKul+oS6CXOX27qJw7E5xR6dTFyQltSWlairu7fLDIJQmUyEtJlh5M L+PN073vbJo/5NwmSo4svS02DaXjcUfhaXgYr/6UAd65jHILy3kpRowRkNxEZeexVmiu Cx/Gh7Do4qsNVvK4MtpHauaLxzQYxyqqXgdd1TwX+3BG1AiH5ZgSLYiadkyVThEXER2M 8pbqGWsAtwI4e8frNFZSsDLZUDGRW0rd26KFxYOe7PuiWBC3U7eSlCPjqgTf/m3OY6Ok IHUw==
X-Google-Dkim-Signature v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id; bh=vLi9K2thY2FMA0yC6zhhANB4Nf6FbsliWulsDYYMN7g=; b=Z38wGu/83NEwp+ok/FtSxyS7h2v2OukjWCLZBTPl8tisHn6H1W4NpZIsErBz6FmU+k ZaRvQ08YOHHsZHbqV6wTFYXbw1N1g3QjAHbGs4QKOcfzN+HIp+p+wKO461ve87sgFIef 2n0MOF5PTpv5u8NKG5ux3s/ab+hB05ZjMz/FQ2eJEVaiB84WTXIBM7Do3At5jM5wSQ1C EAAEQYhPA6DcJlAldy7EEEGZWkYMRdT0EqavFSz1k6xJ0HEOc61/dO6cSQ+71byRy/wz GE13BJ15BJeLIbQUS5lGVGIGxpiYszNd2c+QIYwyXcbqA9NWn1BpBIF7c061cFUHeqsQ Vxag==
X-Gm-Message-State AMke39kESw5IcArVWVbtMDWkRyGuWy/ei6d23oQbURtMM6RoFU2i/gn+QF2Q/Gh2Z3Sahw==
X-Received by 10.28.146.207 with SMTP id u198mr8310077wmd.36.1487173647479; Wed, 15 Feb 2017 07:47:27 -0800 (PST)
X-Mailer git-send-email 2.7.4
Sender robomod@news.nic.it
List-ID <linux-kernel.vger.kernel.org>
X-Mailing-List linux-kernel@vger.kernel.org
Approved robomod@news.nic.it
Lines 27
Organization linux.* mail to news gateway
X-Original-Cc linux-pm@vger.kernel.org, linux-kernel@vger.kernel.org, nicolassaenzj@gmail.com, Daniel Perez <danielperezdeandres@gmail.com>
X-Original-Date Wed, 15 Feb 2017 16:46:21 +0100
X-Original-Message-ID <1487173581-19388-1-git-send-email-danielperezdeandres@gmail.com>
X-Original-Sender linux-kernel-owner@vger.kernel.org
Xref csiph.com linux.kernel:1581410

Show key headers only | View raw


v1 -> v2:
 - given Joe Perches' comment, I've further simplified the syntax
   of the bool function, removing the ternary conditional

Signed-off-by: Daniel Perez <danielperezdeandres@gmail.com>
---
 drivers/power/supply/sbs-charger.c | 5 +----
 1 file changed, 1 insertion(+), 4 deletions(-)

diff --git a/drivers/power/supply/sbs-charger.c b/drivers/power/supply/sbs-charger.c
index 353765a..15947db 100644
--- a/drivers/power/supply/sbs-charger.c
+++ b/drivers/power/supply/sbs-charger.c
@@ -137,10 +137,7 @@ static enum power_supply_property sbs_properties[] = {
 
 static bool sbs_readable_reg(struct device *dev, unsigned int reg)
 {
-	if (reg < SBS_CHARGER_REG_SPEC_INFO)
-		return false;
-	else
-		return true;
+	return reg >= SBS_CHARGER_REG_SPEC_INFO;
 }
 
 static bool sbs_volatile_reg(struct device *dev, unsigned int reg)
-- 
2.7.4

Back to linux.kernel | Previous | Next | Find similar | Unroll thread


Thread

[PATCH v2] Power: supply: sbs-charger: simplified bool function Daniel Perez <danielperezdeandres@gmail.com> - 2017-02-15 16:50 +0100

csiph-web