Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]
Groups > linux.kernel > #1583741
| From | Andrea Arcangeli <aarcange@redhat.com> |
|---|---|
| Newsgroups | linux.kernel |
| Subject | Re: [PATCH] userfaultfd: hugetlbfs: add UFFDIO_COPY support for shared mappings |
| Date | 2017-02-17 22:00 +0100 |
| Message-ID | <tbXNg-IP-17@gated-at.bofh.it> (permalink) |
| References | <tbfCy-5jD-33@gated-at.bofh.it> <tbzhU-1Tc-1@gated-at.bofh.it> <tbErf-5k2-1@gated-at.bofh.it> <tbT6V-6aX-11@gated-at.bofh.it> <tbXax-tp-9@gated-at.bofh.it> |
| Organization | linux.* mail to news gateway |
On Fri, Feb 17, 2017 at 12:17:38PM -0800, Andrew Morton wrote: > I merged this up and a small issue remains: Great! > The value of `err' here is EINVAL. That sems appropriate, but it only > happens by sheer luck. It might have been programmer luck but just for completeness, at runtime no luck was needed (the temporary setting to ENOENT is undoed before the if clause is closed). Your addition is surely safer just in case of future changes missing how we inherited the EINVAL in both branches, thanks! (plus the compiler should be able to optimize it away until after it will be needed)
Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread
[PATCH] userfaultfd: hugetlbfs: add UFFDIO_COPY support for shared mappings Mike Kravetz <mike.kravetz@oracle.com> - 2017-02-15 22:50 +0100
Re: [PATCH] userfaultfd: hugetlbfs: add UFFDIO_COPY support for shared mappings Andrea Arcangeli <aarcange@redhat.com> - 2017-02-16 19:50 +0100
Re: [PATCH] userfaultfd: hugetlbfs: add UFFDIO_COPY support for shared mappings Mike Kravetz <mike.kravetz@oracle.com> - 2017-02-17 01:20 +0100
Re: [PATCH] userfaultfd: hugetlbfs: add UFFDIO_COPY support for shared mappings Andrea Arcangeli <aarcange@redhat.com> - 2017-02-17 17:00 +0100
Re: [PATCH] userfaultfd: hugetlbfs: add UFFDIO_COPY support for shared mappings Andrew Morton <akpm@linux-foundation.org> - 2017-02-17 21:20 +0100
Re: [PATCH] userfaultfd: hugetlbfs: add UFFDIO_COPY support for shared mappings Andrea Arcangeli <aarcange@redhat.com> - 2017-02-17 22:00 +0100
Re: [PATCH] userfaultfd: hugetlbfs: add UFFDIO_COPY support for shared mappings Andrew Morton <akpm@linux-foundation.org> - 2017-02-17 22:10 +0100
Re: [PATCH] userfaultfd: hugetlbfs: add UFFDIO_COPY support for shared mappings Andrea Arcangeli <aarcange@redhat.com> - 2017-02-17 22:40 +0100
Re: [PATCH] userfaultfd: hugetlbfs: add UFFDIO_COPY support for shared mappings "Kirill A. Shutemov" <kirill@shutemov.name> - 2017-02-21 14:30 +0100
Re: [PATCH] userfaultfd: hugetlbfs: add UFFDIO_COPY support for shared mappings Andrea Arcangeli <aarcange@redhat.com> - 2017-02-22 16:20 +0100
Re: [PATCH] userfaultfd: hugetlbfs: add UFFDIO_COPY support for shared mappings "Kirill A. Shutemov" <kirill@shutemov.name> - 2017-02-23 16:00 +0100
csiph-web