Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]
Groups > linux.kernel > #1583687
| From | Michał Zegan <webczat@webczatnet.pl> |
|---|---|
| Newsgroups | linux.kernel |
| Subject | Re: [PATCH 2/2] mmc: meson-gx: remove mmc host on device removal |
| Date | 2017-02-17 21:00 +0100 |
| Message-ID | <tbWRc-72-23@gated-at.bofh.it> (permalink) |
| References | <tbvHk-7E6-19@gated-at.bofh.it> <tbvHk-7E6-21@gated-at.bofh.it> <tbWHw-8v1-9@gated-at.bofh.it> |
| Organization | linux.* mail to news gateway |
W dniu 17.02.2017 o 20:47, Kevin Hilman pisze: > Michał Zegan <webczat@webczatnet.pl> writes: > >> The mmc host was added in meson_mmc_probe, but never removed in meson_mmc_remove. >> Fix that by removing the host before deallocating other resources. >> >> Signed-off-by: Michał Zegan <webczat@webczatnet.pl> > Reviewed-by: Kevin Hilman <khilman@baylibre.com> I do not know how the mmc driver looks like after Heiner's cleanup. Does this patch get obsoleted by the prior cleanup, or conflict with it in some way? > >> --- >> drivers/mmc/host/meson-gx-mmc.c | 2 ++ >> 1 file changed, 2 insertions(+) >> >> diff --git a/drivers/mmc/host/meson-gx-mmc.c b/drivers/mmc/host/meson-gx-mmc.c >> index d444b6bfa02b..bb83446118a3 100644 >> --- a/drivers/mmc/host/meson-gx-mmc.c >> +++ b/drivers/mmc/host/meson-gx-mmc.c >> @@ -818,6 +818,8 @@ static int meson_mmc_remove(struct platform_device *pdev) >> if (WARN_ON(!host)) >> return 0; >> >> + mmc_remove_host(host->mmc); >> + >> if (host->bounce_buf) >> dma_free_coherent(host->dev, host->bounce_buf_size, >> host->bounce_buf, host->bounce_dma_addr);
Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread
[PATCH 2/2] mmc: meson-gx: remove mmc host on device removal Michał Zegan <webczat@webczatnet.pl> - 2017-02-16 16:00 +0100
Re: [PATCH 2/2] mmc: meson-gx: remove mmc host on device removal Kevin Hilman <khilman@baylibre.com> - 2017-02-17 20:50 +0100
Re: [PATCH 2/2] mmc: meson-gx: remove mmc host on device removal Michał Zegan <webczat@webczatnet.pl> - 2017-02-17 21:00 +0100
Re: [PATCH 2/2] mmc: meson-gx: remove mmc host on device removal Kevin Hilman <khilman@baylibre.com> - 2017-02-18 00:10 +0100
csiph-web