Re: [PATCH 1/2] mmc: meson-gx: prevent cfg_div_clk from being disabled on init

From	Kevin Hilman <khilman@baylibre.com>
Newsgroups	linux.kernel
Subject	Re: [PATCH 1/2] mmc: meson-gx: prevent cfg_div_clk from being disabled on init
Date	2017-02-17 20:50 +0100
Message-ID	<tbWHw-8v1-15@gated-at.bofh.it> (permalink)
References	<tbvHk-7E6-19@gated-at.bofh.it> <tbvHk-7E6-17@gated-at.bofh.it>
Organization	BayLibre

Show all headers | View raw

Michał Zegan <webczat@webczatnet.pl> writes:

> At the end of function meson_mmc_clk_init, the cfg_div clock was
> prepared, enabled and configured, but then immediately disabled due to bogus if statements.
> That made later calls to clk_disable_unprepare executed during module removal to fail with a kernel warning.
> Fix that by changing the code to disable clock only when it failed to be configured.
>
> Signed-off-by: Michał Zegan <webczat@webczatnet.pl>

I believe this one is not needed any more after Heiner's cleanups?

Kevin

Back to linux.kernel | Previous | Next — Previous in thread | Find similar | Unroll thread

Thread

[PATCH 1/2] mmc: meson-gx: prevent cfg_div_clk from being disabled on init Michał Zegan <webczat@webczatnet.pl> - 2017-02-16 16:00 +0100
  Re: [PATCH 1/2] mmc: meson-gx: prevent cfg_div_clk from being  disabled on init Michał Zegan <webczat@webczatnet.pl> - 2017-02-17 20:50 +0100
  Re: [PATCH 1/2] mmc: meson-gx: prevent cfg_div_clk from being disabled on init Kevin Hilman <khilman@baylibre.com> - 2017-02-17 20:50 +0100

csiph-web